Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: cellular: modem_shell: Fix errors when printing link status #20334

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

tokangas
Copy link
Contributor

When registration had already been dropped, a couple of errors were shown when trying to print registration and PDN status. AT response parsing has been improved to handle also this situation.

MOSH-640

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 13, 2025
@tokangas tokangas removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 13, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 13, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 6ff1d86725994ad1eb154505e774357b0ddd27f4

more details

sdk-nrf:

PR head: 6ff1d86725994ad1eb154505e774357b0ddd27f4
merge base: 859caae972f33e147649af67aea71e00c35006a2
target head (main): 50841a0690267d9e98f884672233538d393f1032
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
samples
│  ├── cellular
│  │  ├── modem_shell
│  │  │  ├── src
│  │  │  │  ├── link
│  │  │  │  │  ├── link.c
│  │  │  │  │  │ link_api.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_bbe5b33786

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 226
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

When registration had already been dropped, a couple of errors
were shown when trying to print registration and PDN status.
AT response parsing has been improved to handle also this
situation.

MOSH-640

Signed-off-by: Tommi Kangas <[email protected]>
@tokangas tokangas force-pushed the mosh_link_status_fix branch from a831f65 to 6ff1d86 Compare February 13, 2025 11:48
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 13, 2025
@tokangas tokangas removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 13, 2025
@rlubos rlubos merged commit 8caef9d into nrfconnect:main Feb 13, 2025
13 checks passed
@tokangas tokangas deleted the mosh_link_status_fix branch February 13, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants