log: print capacity of the sidewalk workq #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.config diff |
RobertGalatNordic
force-pushed
the
add_log_to_sidewalk_workq
branch
8 times, most recently
from
6ac6d11 to
fcdcd16
Compare
ktaborowski
reviewed
Feb 11, 2025
RobertGalatNordic
force-pushed
the
add_log_to_sidewalk_workq
branch
2 times, most recently
from
d50a6ad to
aba0da0
Compare
ktaborowski
reviewed
Feb 13, 2025
| @@ -68,4 +68,17 @@ void sidewalk_event_link_switch(sidewalk_ctx_t *sid, void *ctx); | |||
| void sidewalk_event_exit(sidewalk_ctx_t *sid, void *ctx); | |||
| void sidewalk_event_reboot(sidewalk_ctx_t *sid, void *ctx); | |||
| void sidewalk_event_platform_init(sidewalk_ctx_t *sid, void *ctx); | |||
|
|
|||
| #define EVENT_TO_NAME(event) \ | |||
| event == sidewalk_event_process ? "sidewalk_event_process" : \ | |||
There was a problem hiding this comment.
minor: use a shorter prefix e.g. sid_ev
| } | ||
| case -EAGAIN: | ||
| case -ENOMSG: { | ||
| // Do nothing, timeout |
There was a problem hiding this comment.
minor: LOG_DBG("Sidewalk msgq timeout"); ?
| if (event.handler) { | ||
| event.handler(sid, event.ctx); | ||
| } | ||
| if (event.ctx_free) { | ||
| event.ctx_free(event.ctx); | ||
| } | ||
| } else { | ||
| if (event.handler != sidewalk_event_process) { | ||
| sidewalk_event_process(sid, NULL); |
There was a problem hiding this comment.
I don't understand this. Most events triggers sid process, and it will be added to msgq anyway. Moreover it adds extra load to queue.
ktaborowski
approved these changes
Feb 13, 2025
RobertGalatNordic
force-pushed
the
add_log_to_sidewalk_workq
branch
from
aba0da0 to
caaa1cc
Compare
add logs to track queue usage Signed-off-by: Robert Gałat <[email protected]>
RobertGalatNordic
force-pushed
the
add_log_to_sidewalk_workq
branch
from
caaa1cc to
0b331f9
Compare
totyz
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase workq size and show usage
CI parameters
Description
JIRA ticket:
Self review