modules: hal_nordic: nRF 802.15.4 customizable asserts #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankuns
force-pushed
the
pr/nrf802154_asserts
branch
from
2e91f30 to
74b2a60
Compare
ankuns
force-pushed
the
pr/nrf802154_asserts
branch
from
74b2a60 to
7c0d57e
Compare
hubertmis
reviewed
Dec 4, 2023
Comment on lines
+14
to
+18
| #ifdef CONFIG_USERSPACE | ||
| /* User threads aren't allowed to induce kernel panics; generate | ||
| * an oops instead. | ||
| */ | ||
| if (k_is_user_context()) { |
There was a problem hiding this comment.
Why k_panic() is used here at all? Isn't k_oops() a better choice?
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm not convinced a driver fault is considered a kernel fault. But I won't block this PR because of this.
hubertmis
approved these changes
Dec 4, 2023
Comment on lines
+14
to
+18
| #ifdef CONFIG_USERSPACE | ||
| /* User threads aren't allowed to induce kernel panics; generate | ||
| * an oops instead. | ||
| */ | ||
| if (k_is_user_context()) { |
There was a problem hiding this comment.
I'm not convinced a driver fault is considered a kernel fault. But I won't block this PR because of this.
ankuns
force-pushed
the
pr/nrf802154_asserts
branch
from
7c0d57e to
ed3e823
Compare
jciupis
approved these changes
Dec 4, 2023
ankuns
force-pushed
the
pr/nrf802154_asserts
branch
from
ed3e823 to
8fa697c
Compare
LuDuda
approved these changes
Dec 4, 2023
ankuns
force-pushed
the
pr/nrf802154_asserts
branch
from
8fa697c to
67b4158
Compare
ankuns
force-pushed
the
pr/nrf802154_asserts
branch
from
67b4158 to
42cc3aa
Compare
anangl
approved these changes
Dec 11, 2023
Recent nRF 802.15.4 Radio Driver provides assert abstraction layer. The assert abstraction layer is implemented in Zephyr in following ways depending on the `NRF_802154_ASSERT_CHOICE` Kconfig choice. `NRF_802154_ASSERT_ZEPHYR_MINIMAL` (default) gives ability to still perform run-time checking of the nRF 802.15.4 Radio Driver operation with minimum memory overhead and configurable behavior on fault detection regardless of the `CONFIG_ASSERT` Kconfig option value. `NRF_802154_ASSERT_ZEPHYR` gives ability to use asserts provided and configurable by Zephyr including the ability to turn off the run-time checking of the nRF 802.15.4 Radio Driver operation. Signed-off-by: Andrzej Kuroś <[email protected]> (cherry picked from commit f5337fc)
ankuns
force-pushed
the
pr/nrf802154_asserts
branch
from
42cc3aa to
46b1970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent nRF 802.15.4 Radio Driver provides assert abstraction layer. The assert abstraction layer is implemented in Zephyr in following ways depending on the
NRF_802154_ASSERT_CHOICEKconfig choice.NRF_802154_ASSERT_ZEPHYR_MINIMAL(default) gives ability to still perform run-time checking of the nRF 802.15.4 Radio Driver operation with minimum memory overhead and configurable behavior on fault detection regardless of theCONFIG_ASSERTKconfig option value.NRF_802154_ASSERT_ZEPHYRgives ability to use asserts provided and configurable by Zephyr including the ability to turn off the run-time checking of the nRF 802.15.4 Radio Driver operation.Related JIRA ticket: KRKNWK-18116