[nrf noup] ci: Add PMIC samples change scope #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanthanordic
requested review from
thst-nordic
and removed request for
a team
aasinclair
reviewed
Jan 8, 2024
| "CI-pmic-samples-test": | ||
| - "/samples/shields/npm1300_ek/**/*" | ||
| - "/boards/shields/npm1300_ek/**/*" | ||
| - "**/**npm1300**/**" |
There was a problem hiding this comment.
I think this should be
Suggested change
| - "**/**npm1300**/**" | |
| - "**npm1300**" |
Also, do we need the two previous lines?
Happy to leave them if you would like to keep them to make it clear.
There was a problem hiding this comment.
Without /**s it doesn't work for nested folders. Here's the link to groovy playground setup I've used for testing: https://onecompiler.com/groovy/3zytxfuz5
Also, do we need the two previous lines?
Strictly no, but I would like to keep it explicit.
aasinclair
approved these changes
Jan 8, 2024
magnev
approved these changes
Jan 9, 2024
Add change scope to run test suite for PMIC samples Signed-off-by: Vladislav Litvinov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added change scope to run test suite for PMIC samples.