[nrf fromlist] drivers: ieee802154: fix nRF5 Rx error handling #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit zephyrproject-rtos/zephyr@b85cb9a pushed to upstream PR, please update here. |
jciupis
force-pushed
the
pr/fix-ieee802154-nrf5-csl-endpoint-cherrypick
branch
from
5cea8a6 to
172286f
Compare
|
@ankuns done. |
The current implementation implicitly assumes that if the device is configured to have the capability of acting as a CSL endpoint then in case a delayed reception with matching ID finishes with a timeout no action is needed. This assumption is correct when RxOnWhenIdle mode is disabled because the transition to sleep is done automatically by the driver below. However, it's wrong when RxOnWhenIdle is enabled. This commit fixes that case by adding a call to event handler that notifies the higher layer about the event and allows it to transition to RxOff if needed. Upstream PR: zephyrproject-rtos/zephyr#67774 Signed-off-by: Jędrzej Ciupis <[email protected]>
jciupis
force-pushed
the
pr/fix-ieee802154-nrf5-csl-endpoint-cherrypick
branch
from
172286f to
68af78a
Compare
ankuns
approved these changes
Jan 19, 2024
dawidprzybylo
approved these changes
Jan 19, 2024
ankuns
added a commit
to ankuns/sdk-nrfxlib
that referenced
this pull request
Jan 19, 2024
The nrf_rtc_timer allows dependency inversion. The nRF 802.15.4 Radio Driver now expresses an additive requirement on the number of user channels of nrf_rtc_timer by setting Kconfig option NRF_RTC_TIMER_USER_CHAN_COUNT_ADD_* Related sdk-zephyr PR, which introduces the feature to the nrf_rtc_timer: nrfconnect/sdk-zephyr#1455 Signed-off-by: Andrzej Kuros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation implicitly assumes that if the device is configured to have the capability of acting as a CSL endpoint then in case a delayed reception with matching ID finishes with a timeout no action is needed. This assumption is correct when RxOnWhenIdle mode is disabled because the transition to sleep is done automatically by the driver below. However, it's wrong when RxOnWhenIdle is enabled. This commit fixes that case by adding a call to event handler that notifies the higher layer about the event and allows it to transition to RxOff if needed.
Upstream PR: zephyrproject-rtos/zephyr#67774