Cherrypick fixes for ACK header IE related bugs #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
requested review from
canisLupus1313,
edmont,
jukkar and
rlubos
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
maciejbaczmanski
changed the title
maciejbaczmanski
force-pushed
the
ot_enh_ack_fix_ncs_pr
branch
2 times, most recently
from
9822ed9 to
6f4be47
Compare
edmont
approved these changes
Jan 26, 2024
jciupis
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
It seems that the commit message of the revert refers to maciejbaczmanski@1da00e0 instead of 1da00e0. Please correct it to keep a valid reference to the commit in the future.
Other than that - lovely 👍
that's weird because commit message does not contain any remote references: |
…IE config" This reverts commit nrfconnect@1da00e0 Signed-off-by: Maciej Baczmanski <[email protected]>
- In `set_vendor_ie_header_lm`, case when `link_metrics_data_len == 0` has been ignored. This commit fixes that by setting `header_ie->length = 0` before returning. - current implementation of enh ACK header IE returns `-ENOTSUP` when `ack_ie.header_ie == NULL` or `ack_ie.header_ie->length == 0`. This commit fixes that by refactoring checks in `nrf5_configure`. Co-authored-by: Przemyslaw Bida <[email protected]> Signed-off-by: Maciej Baczmanski <[email protected]> (cherry picked from commit d76bcd3)
…4_config` `struct ieee802154_config config` is a struct containing an union. Members of `config` were accessed incorrectly in `otPlatRadioEnableCsl`. Fix by initializing `config` with `0` and accessing one member at a time. Signed-off-by: Maciej Baczmanski <[email protected]> (cherry picked from commit 36b7f44)
additionaly, implement `otPlatRadioResetCsl` functionality Signed-off-by: Maciej Baczmanski <[email protected]> (cherry picked from commit 0f1747e)
maciejbaczmanski
force-pushed
the
ot_enh_ack_fix_ncs_pr
branch
from
6f4be47 to
104e695
Compare
rlubos
approved these changes
Jan 26, 2024
kszewenko
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert hotfix from PR: #1441
Fix bugs in current implementation of ieee802154 driver:
set_vendor_ie_header_lm, case whenlink_metrics_data_len == 0has been ignored. Fixed by refactoring the code again.-ENOTSUPreturned). Fixed by implementingotPlatRadioResetCslin upstream OpenThread and addingclear_ieflag.-ENOTSUPwhenack_ie.header_ie == NULL(set when csl period set to 0 inotPlatRadioEnableCsl), becauseieee802154_header_ie_get_element_idaccessedNULLpointer.struct ieee802154_config configis a struct containing an union. Members ofconfigwere accessed incorrectly inotPlatRadioEnableCsl. Fixed by initializingconfigwith0and accessing one member at a time.Cherry-picked from: