Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf fromtree] boards: arm: mark counter as supported for nRF54L15 #1663

Closed
wants to merge 1 commit into from

Conversation

nordic-krch
Copy link
Contributor

Mark counter as supported for nRF54L15 to allow running counter_basic_api by twister.

Signed-off-by: Magdalena Pastula [email protected]
(cherry picked from commit 76f9907)

Mark counter as supported for nRF54L15 to allow running
counter_basic_api by twister.

Signed-off-by: Magdalena Pastula <[email protected]>
(cherry picked from commit 76f9907)
Copy link
Contributor

@anangl anangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit is different from the upstream one (a different file is modified), so it should be taken as [nrf fromlist].

@anangl anangl requested review from tejlmand and gmarull April 24, 2024 07:28
@gmarull
Copy link
Member

gmarull commented Apr 24, 2024

note: tuned commits to accommodate HWMv2 changes are allowed until upmerge completes, but not any other kind of changes.

@gmarull gmarull requested a review from anangl April 24, 2024 13:34
Copy link
Contributor

@anangl anangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: tuned commits to accommodate HWMv2 changes are allowed until upmerge completes, but not any other kind of changes.

OK, then my -1 turns out to be undesirable.

@nordic-krch
Copy link
Contributor Author

The commit is different from the upstream one (a different file is modified),

I did cherry-pick -x and git figured out that that's the file that changed location.

@nordic-krch nordic-krch closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants