net: lib: coap_client: Improve cancel function #1667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
2 times, most recently
from
5f32af8 to
360b989
Compare
|
@juhaylinen @SeppoTakalo -- I would like your early review of this. If you agree with the approach then I will create an upstream PR and add the appropriate sauce tag here. |
SeppoTakalo
reviewed
Apr 25, 2024
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
2 times, most recently
from
55162d0 to
544ff88
Compare
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
from
303d143 to
ae91c6d
Compare
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
2 times, most recently
from
93a5804 to
6f429b1
Compare
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
from
6f429b1 to
b9f5451
Compare
plskeggs
changed the title
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
2 times, most recently
from
a52c071 to
b8ee665
Compare
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
2 times, most recently
from
d948199 to
8897b2a
Compare
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
from
8897b2a to
8449afd
Compare
glarsennordic
approved these changes
May 17, 2024
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
from
8449afd to
9266e96
Compare
SeppoTakalo
reviewed
May 17, 2024
SeppoTakalo
approved these changes
May 17, 2024
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
from
9266e96 to
b53dfab
Compare
|
@carlescufi I updated my commit in this PR to be |
juhaylinen
approved these changes
May 20, 2024
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
2 times, most recently
from
535db7f to
788b038
Compare
The coap_client lib only handled "one-shot" requests properly. This patch allows it to keep listening for additional responses to a request, if the request was made with the CoAP OBSERVE option appended. An API for canceling such requests is also added. Signed-off-by: Benjamin Lindqvist <[email protected]> (cherry picked from commit 0d14143)
Improve coap_client_cancel_requests(). Ensure it can be called from a callback. Report error to waiting callbacks. Clear active flag. This is useful when the network becomes unavailable or prior to disconnecting in order to save power. Signed-off-by: Pete Skeggs <[email protected]> (cherry picked from commit f04f8b2)
plskeggs
force-pushed
the
feature-coap-client-cancel
branch
from
788b038 to
43dc8c6
Compare
|
No longer necessary; the upstream PR merged and was included in the recent upmerge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve coap_client_cancel_requests(). Ensure it can be called from a callback. Clear pending reqs. Report error to waiting callbacks. Clear active flag.
This is useful when the network becomes unavailable or prior to disconnecting in order to save power.
(cherry picked from commit f04f8b2)