[nrf noup] Bluetooth: Mesh: remove legacy adv support #1725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxelax
requested changes
May 21, 2024
HaavardRei
force-pushed
the
remove-legacy-adv-support-for-sdc-in-ncs
branch
from
678d720 to
1716c49
Compare
HaavardRei
added a commit
to HaavardRei/sdk-nrf
that referenced
this pull request
May 21, 2024
[nrf noup] Bluetooth: Mesh: remove legacy adv support nrfconnect/sdk-zephyr#1725 Signed-off-by: Håvard Reierstad <[email protected]>
alxelax
approved these changes
May 21, 2024
HaavardRei
force-pushed
the
remove-legacy-adv-support-for-sdc-in-ncs
branch
from
1716c49 to
aaca41a
Compare
HaavardRei
added a commit
to HaavardRei/sdk-nrf
that referenced
this pull request
May 22, 2024
[nrf noup] Bluetooth: Mesh: remove legacy adv support nrfconnect/sdk-zephyr#1725 Signed-off-by: Håvard Reierstad <[email protected]>
ludvigsj
approved these changes
May 22, 2024
HaavardRei
force-pushed
the
remove-legacy-adv-support-for-sdc-in-ncs
branch
from
aaca41a to
8a2c10a
Compare
HaavardRei
added a commit
to HaavardRei/sdk-nrf
that referenced
this pull request
May 28, 2024
[nrf noup] Bluetooth: Mesh: remove legacy adv support nrfconnect/sdk-zephyr#1725 Signed-off-by: Håvard Reierstad <[email protected]>
HaavardRei
force-pushed
the
remove-legacy-adv-support-for-sdc-in-ncs
branch
from
8a2c10a to
4e79304
Compare
NordicBuilder
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic,
nika-nordic and
omkar3141
HaavardRei
added a commit
to HaavardRei/sdk-nrf
that referenced
this pull request
May 29, 2024
[nrf noup] Bluetooth: Mesh: remove legacy adv support nrfconnect/sdk-zephyr#1725 Signed-off-by: Håvard Reierstad <[email protected]>
omkar3141
approved these changes
May 29, 2024
Changes twister tests and nrf samples from using legacy adv to ext adv since this is the default for Mesh. Legacy adv is still tested in bsim. Removes redundant test configuration testing ext adv. Removes redundant config for ext_adv in `multi_ext_adv.conf`. Signed-off-by: Håvard Reierstad <[email protected]> Upstream PR: zephyrproject-rtos/zephyr#73318
Removes explicit support for the legacy advertiser due to incompatibility with SDC. The legacy advertiser can be used (experimentally) with the Zephyr Link Layer enabled, but is not recommended. Signed-off-by: Håvard Reierstad <[email protected]>
HaavardRei
force-pushed
the
remove-legacy-adv-support-for-sdc-in-ncs
branch
from
4e79304 to
11529af
Compare
HaavardRei
added a commit
to HaavardRei/sdk-nrf
that referenced
this pull request
May 31, 2024
[nrf noup] Bluetooth: Mesh: remove legacy adv support nrfconnect/sdk-zephyr#1725 Signed-off-by: Håvard Reierstad <[email protected]>
HaavardRei
added a commit
to HaavardRei/sdk-nrf
that referenced
this pull request
May 31, 2024
[nrf noup] Bluetooth: Mesh: remove legacy adv support nrfconnect/sdk-zephyr#1725 Signed-off-by: Håvard Reierstad <[email protected]>
HaavardRei
added a commit
to HaavardRei/sdk-nrf
that referenced
this pull request
May 31, 2024
[nrf noup] Bluetooth: Mesh: remove legacy adv support nrfconnect/sdk-zephyr#1725 Signed-off-by: Håvard Reierstad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes explicit support for the legacy advertiser due to incompatibility with SDC.
The legacy advertiser can be used (experimentally) with the Zephyr Link Layer enabled, but is not recommended.