[Backport v2.2-branch] Bluetooth: Controller: Fix device address in Periodic Adv Sync #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The address type in the periodic adveritising sync established event is incorrectly set to 0x01 (BT_ADDR_LE_RANDOM) when the address is a resolved one, where it should have been BT_ADDR_LE_RANDOM_ID. The address type has been fixed by offsetting by 2 to get BT_ADDR_LE_PUBLIC_ID or BT_ADDR_LE_RANDOM_ID when the address has been resolved. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]> (cherry picked from commit 278b07c) Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
When the AUX_ADV_IND and AUX_SYNC_IND are close to each other, the duration between them is not sufficient to schedule a new instance of ticker to establish synchronization. This processing time introduces latencies detected by the prepare callback. When the sync offset is low, schedule the start of the reception to next periodic interval. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]> (cherry picked from commit bd5e906) Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix incorrect device address reported in the LE Periodic Advertising Sync Established event when using Periodic Advertiser List. During Extended Scanning there can be an ADV_EXT_IND PDU received between currently being received ADV_EXT_IND PDU and AUX_ADV_IND PDU; if the one received between has an address match then incorrectly the Periodic Synchronization was established to the device whos AUX_ADV_IND PDU is being received. Fix by storing the auxiliary context that has the address match and compare with it when matching the SID in SyncInfo of AUX_ADV_IND PDU being received prior to creating the synchronization. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect device address reported in the LE Periodic
Advertising Sync Established event when using Periodic
Advertiser List.
During Extended Scanning there can be an ADV_EXT_IND PDU
received between currently being received ADV_EXT_IND PDU
and AUX_ADV_IND PDU; if the one received between has an
address match then incorrectly the Periodic Synchronization
was established to the device whos AUX_ADV_IND PDU is being
received. Fix by storing the auxiliary context that has the
address match and compare with it when matching the SID in
SyncInfo of AUX_ADV_IND PDU being received prior to creating
the synchronization.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]