Skip to content

modules: hal_nordic: bump regtool to 9.0.1 #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2025
Merged

modules: hal_nordic: bump regtool to 9.0.1 #2663

merged 4 commits into from
Apr 14, 2025

Conversation

jonathannilsen
Copy link
Contributor

@jonathannilsen jonathannilsen commented Mar 25, 2025 •
edited
Loading

Upstream PR #: 88055

Added support for VPR GPIOs and a more concise output print.

@NordicBuilder NordicBuilder mentioned this pull request Mar 25, 2025
Merged
@jonathannilsen jonathannilsen force-pushed the regtool-9.0.0 branch 4 times, most recently from c1341c3 to 51f6d6d Compare March 26, 2025 07:47
@jonathannilsen jonathannilsen requested a review from a team March 26, 2025 07:49
@jonathannilsen jonathannilsen changed the title [nrf fromlist] modules: hal_nordic: bump regtool to 9.0.0 [nrf fromtree] modules: hal_nordic: bump regtool to 9.0.0 Apr 1, 2025
@jonathannilsen jonathannilsen force-pushed the regtool-9.0.0 branch 2 times, most recently from 1e564d3 to 3d98097 Compare April 2, 2025 14:08
@jonathannilsen jonathannilsen changed the title [nrf fromtree] modules: hal_nordic: bump regtool to 9.0.0 modules: hal_nordic: bump regtool to 9.0.1 Apr 2, 2025
@jonathannilsen
Copy link
Contributor Author

A bug was found before this got integrated into NCS, so I've now updated to 9.0.1 here

@jonathannilsen jonathannilsen force-pushed the regtool-9.0.0 branch 3 times, most recently from 963bc21 to 087ff85 Compare April 10, 2025 10:55
@jonathannilsen jonathannilsen force-pushed the regtool-9.0.0 branch 3 times, most recently from 408a7d4 to e09be9d Compare April 13, 2025 13:42
rlubos
rlubos previously requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the noup commit titles, we don't add special tags for reverts or reapplies, it'd confuse our tooling. The revert commit should use the default title:
Revert "[nrf noup] moduled: hal_nordic: require nrf-regtool"
And then the replied commit description should just be an exact copy of the original one:
[nrf noup] moduled: hal_nordic: require nrf-regtool

@jonathannilsen jonathannilsen requested a review from rlubos April 14, 2025 11:39
@rlubos
Copy link
Contributor

rlubos commented Apr 14, 2025

@jonathannilsen The revert still has the redundant prefix, it should be Revert "[nrf noup] moduled: hal_nordic: require nrf-regtool"

jonathannilsen and others added 4 commits April 14, 2025 13:44
@jonathannilsen
Revert "[nrf noup] moduled: hal_nordic: require nrf-regtool"
3ade540 
This reverts commit 6ec9d10.

Signed-off-by: Jonathan Nilsen <[email protected]>
@jonathannilsen
[nrf fromtree] modules: hal_nordic: bump regtool to 9.0.0
7ee3cfd 
(cherry picked from commit 8e1f27a)

Added support for VPR GPIOs and a more concise output print.

Signed-off-by: Jonathan Nilsen <[email protected]>
@jonathannilsen
[nrf fromtree] modules: hal_nordic: bump regtool to 9.0.1
244a5e9 
Fixes an issue where pinctrl psel properties encoded with
NRF_PSEL_DISCONNECTED() caused a build failure.

Signed-off-by: Jonathan Nilsen <[email protected]>
(cherry picked from commit 8c5755c)
@gmarull @jonathannilsen
[nrf noup] moduled: hal_nordic: require nrf-regtool
44be7ef 
Upstream not ready yet, revert once applied there.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
Signed-off-by: Karsten Koenig <[email protected]>

(cherry picked from commit 6384b58)
(cherry picked from commit 6ec9d10)

Signed-off-by: Jonathan Nilsen <[email protected]>
@jonathannilsen
Copy link
Contributor Author

@jonathannilsen The revert still has the redundant prefix, it should be Revert "[nrf noup] moduled: hal_nordic: require nrf-regtool"

Ah, thanks, forgot about that one, should be fixed now.

@rlubos rlubos dismissed their stale review April 14, 2025 11:47

Commit titles fixed

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rlubos rlubos merged commit d6cefa7 into nrfconnect:main Apr 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karstenkoenig karstenkoenig karstenkoenig approved these changes

@57300 57300 57300 approved these changes

@rlubos rlubos Awaiting requested review from rlubos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathannilsen @rlubos @karstenkoenig @57300 @gmarull