-
Notifications
You must be signed in to change notification settings - Fork 656
boards: nordic: thingy53: Add QSPI nrfutil config #2686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a configuration file which is used with nrfutil to allow programming QSPI on the device Upstream PR #: 86985 Signed-off-by: Jamie McCrae <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update this PR to fetch the changes from the related upstream PR? There are updates for nRf7002DK as well. To work with this change, we need this one: zephyrproject-rtos/zephyr@2effae5 . Without having that in sdk-zephyr, nrfutil runner doesn't have --ext-mem-config-file
argument. Could you please add it as well?
…rnal memory Both backends supported as runners for nRF ICs, nrfjprog and nrfutil, support erasing external memory as part of the programming operation. Before this patch, and when the firmware was detected to be partially or fully placed in external flash by inspecting the .hex address range, the runner would instruct the backend tool to fully erase the external flash (but the nrfjprog runner would ignore that, always erasing only the sectors required). Instead, correctly default to erasing only the sectors that are required to program the new firmware image in both tools, and erase it completely only when the --erase flag is provided by the user. Signed-off-by: Carles Cufi <[email protected]> (cherry picked from commit f20168f)
…onfig param This acts in a similar way to nrfjprog's --qspiini parameter introduced in 7eb364b, but works slightly differently in nrfutil: it requires a config file in JSON format instead of .ini, and it is passed along to the `execute-batch` command instead of providing it together with the `program` command. Signed-off-by: Carles Cufi <[email protected]> (cherry picked from commit 2effae5)
@carlescufi Seems that one more commit is missing: zephyrproject-rtos/zephyr@8e4c889. It contains config files for nRF7002DK, which is important to enable it in NCS here: nrfconnect/sdk-nrf#20528. Could you please add it here as well? |
|
It does not apply, so you will need to submit a PR adding that with all the prior require commits so that it applies cleanly without conflicts, which will also involve reverting then re-applying a no-up commit which will need edited |
|
@bjarki-andreasen @tejlmand @carlescufi @de-nordic @nvlsianpu please review |
I've added commits for thingy53 and 7002DK and resolved conflicts: #2694 |
Adds a configuration file which is used with nrfutil to allow programming QSPI on the device