Skip to content

[nrf fromtree] wifi: utils: Fix crash for scan #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

kapbh
Copy link
Contributor

@kapbh kapbh commented Apr 1, 2025

The check for index out of bound is missing, It turns into a crash for input channel more than WIFI_MGMT_SCAN_CHAN_MAX_MANUAL.

The check for index out of bound is missing, It turns into a crash
for input channel more than WIFI_MGMT_SCAN_CHAN_MAX_MANUAL.

Signed-off-by: Kapil Bhatt <[email protected]>
(cherry picked from commit 6f9dbbd)
Copy link

sonarqubecloud bot commented Apr 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@krish2718
Copy link
Contributor

Regarding the SonarQube failure, the category is Maintainability the comments are valid but need invasive changes and too late for 3.0.0, the will be taken care by SHEL-3554 in the upcoming release. @nordicjm @carlescufi @shanthanordic can you please merge this with exception, once the CI is green? WDYT?

@nordicjm
Copy link
Contributor

nordicjm commented Apr 1, 2025

Note: sonar analysis is not mandatory or blocking, just advisory

@nordicjm nordicjm merged commit 34633fc into nrfconnect:main Apr 1, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants