Skip to content

[nrf fromtree] Cherry pick cs complete events with status #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ryanjh
Copy link
Contributor

@ryanjh ryanjh commented Apr 2, 2025

If the HCI status of a complete event is not BT_HCI_ERR_SUCCESS,
the remaining parameters could be invalid.

In this case, the params is passed as NULL pointer to the callbacks.

  • LE CS Read Remote Supported Capabilities Complete event
  • LE CS Read Remote FAE Table Complete event
  • LE CS Config Complete event
  • LE CS Security Enable Complete event
  • LE CS Procedure Enable Complete event

This change avoids forwarding the invalid fileds to the applications.

@ryanjh ryanjh marked this pull request as ready for review April 2, 2025 07:48
@ryanjh ryanjh changed the title Cherry pick cs complete events with status [nrf fromtree] Cherry pick cs complete events with status Apr 2, 2025
ryanjh added 2 commits April 2, 2025 12:13
…plete events

If the HCI status of a complete event is not BT_HCI_ERR_SUCCESS,
the remaining parameters could be invalid.

In this case, the params is passed as NULL pointer to the callbacks.
- LE CS Read Remote Supported Capabilities Complete event
- LE CS Read Remote FAE Table Complete event
- LE CS Config Complete event
- LE CS Security Enable Complete event
- LE CS Procedure Enable Complete event

This change avoids forwarding the invalid fileds to the applications.

Signed-off-by: Ryan Chu <[email protected]>
(cherry picked from commit c9240cc)
… events

The CS complete callbacks provide both status and params.
In the case of errors, NULL pointer is passed to the params of callbacks.

Signed-off-by: Ryan Chu <[email protected]>
(cherry picked from commit 9ba60d3)
@ryanjh ryanjh force-pushed the cherry_pick_cs_complete_events_with_status branch from bd679ca to 9958122 Compare April 2, 2025 10:13
@ivaniushkov ivaniushkov self-requested a review April 2, 2025 10:19
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
24.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Tsjerfell Tsjerfell self-requested a review April 2, 2025 10:45
@rlubos rlubos merged commit e6ab653 into nrfconnect:main Apr 3, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants