-
Notifications
You must be signed in to change notification settings - Fork 667
Configure Enterprise mode in Wi-Fi credentials #2771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49a251b
to
5be027d
Compare
c1fcc13
to
e2805de
Compare
e2805de
to
65591c4
Compare
sachinthegreen
approved these changes
Apr 22, 2025
f0d057a
to
ddf1571
Compare
krish2718
approved these changes
Apr 22, 2025
Add support to read identity and private key password if configured in Enterprise mode. Signed-off-by: Triveni Danda <[email protected]> (cherry picked from commit 589333e)
Fix the kconfig check for enterprise crypto support in AP mode. Also, remove the unnecessary Hostapd enterprise crypto check in credentials code. Signed-off-by: Triveni Danda <[email protected]> (cherry picked from commit b3ea4f8)
Based on few tests, it was observed that WPA supplicant's maximum usage for connection and disconnection is 4360. This would save ~4K which is huge as we have a crunch for RAM. This was missed when hostap was upstreamed from NCS. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 83592e8)
When connecting to a WPA3 connection, the max stack size observed was 5456, fix the SoF by increasing by 200bytes (cushion added). Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 24cbc88)
During experiments it was observed that workqueue uses a maximum of 3872 bytes, so, with cushion added set it to 4096. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 96dc3d3)
In case interface is UP, the interface is added to WPA supplicant in the iface_wq itself and the max stack size is 4264, so, increase the stack size of the iface_wq. If the interface is added via net_mgmt thread then it works fine. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit e2bf746)
…tion Increase stack size of supplicant thread to fix crash seen during enterprise mode connection. Increase heap requirement of hostap to handle TLS processing failures. Signed-off-by: Ravi Dondaputi <[email protected]> (cherry picked from commit d073e62)
ddf1571
to
2d64f67
Compare
carlescufi
requested changes
Apr 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a commit with no tag
2d64f67
to
ec9c985
Compare
Added now |
carlescufi
approved these changes
Apr 22, 2025
c534b53
to
5f682b5
Compare
… security Add support for configuring enterprise mode security. Fixes SHEL-3573. Upstream PR #: 88653 Signed-off-by: Ravi Dondaputi <[email protected]>
Enable Wi-Fi credentials support. Update the heap sizes as required for enterprise mode. Upstream PR #: 88653 Signed-off-by: Ravi Dondaputi <[email protected]>
… overflow Inclusion of CONFIG_WIFI_SHELL_RUNTIME_CERTIFICATES causes build time RAM overflow issues. Decrease NRF_WIFI_DATA_HEAP_SIZE to accommodate the RUNTIME_CERTIFICATES feature. Upstream PR #:88861 Signed-off-by: Ravi Dondaputi <[email protected]>
These are QSPI related which is part of buslib. Upstream PR #: 88897 Signed-off-by: Chaitanya Tata <[email protected]>
These are applicable for Wi-Fi over QSPI (nRF7002DK) or Flash over QSPI (nRF52/53 + nRF7002EK) and as most Wi-Fi samples run on 128MHz (for performance), disable the anomalies for both. Upstream PR #: 88897 Signed-off-by: Chaitanya Tata <[email protected]>
5f682b5
to
ca142fc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to configure Enterprise mode in Wi-Fi credentials.