Skip to content

Rename ncol parameter to ncols #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

tgrandje
Copy link

@tgrandje tgrandje commented Mar 9, 2023

Following this PR in matplotlib (v3.6.0 released in sept. 2022), _ncol was renamed _ncols.

tgrandje added 2 commits March 9, 2023 10:14
Following [this PR](matplotlib/matplotlib@958e329) in matplotlib and the 3.6.0 version released in sept. 2022, _ncol was renamed _ncols
update matplotlib version dependency
@FriedrichFroebel
Copy link

This duplicates both #565 and #558.

@tgrandje
Copy link
Author

tgrandje commented Mar 9, 2023

Sorry, I missed that indeed.
@FriedrichFroebel : do you think the current pyproject.toml (matplotlib's dependecy spec) could be updated in a minor update of the package while awaiting for the next major update ? (I see #565 is 5 months old and still not deployed)

@tgrandje tgrandje closed this Mar 9, 2023
@tgrandje tgrandje deleted the patch_ncol branch March 9, 2023 11:07
@FriedrichFroebel
Copy link

I cannot speak for @nschloe as the author/maintainer of this package, which seems to have not received any relevant updates for about a year now.

@nschloe
Copy link
Owner

nschloe commented Mar 9, 2023

Hey guys, sorry for the delay. I'm terribly busy these days/months which is why I haven't had any time to spend on tpl. I'm planning to make some time soon though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants