Skip to content

Commit

Permalink
ir: Do not hash public keys to check orig/announced SN diff (#2711)
Browse files Browse the repository at this point in the history
  • Loading branch information
roman-khimov authored Jan 15, 2024
2 parents c6a4bff + e123e6e commit 9f4bf88
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Changelog for NeoFS Node
- Zero exit code if IR fails (#2704)
- Neo RPC client failure when the first endpoint is unavailable even if there are more endpoints to try (#2703)
- Incorrect address mapping of the Alphabet contracts in NNS produced by deployment procedure (#2713)
- IR compares and logs public keys difference, not hash of keys difference at SN verification check (#2711)

### Changed
- Created files are not group writable (#2589)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ func compareNodeInfos(niExp, niGot netmap.NodeInfo) error {

var err error

if exp, got := niExp.Hash(), niGot.Hash(); exp != got {
return fmt.Errorf("hash: got %d, expect %d", got, exp)
if exp, got := niExp.PublicKey(), niGot.PublicKey(); !bytes.Equal(exp, got) {
return fmt.Errorf("public key: got %x, expect %x", got, exp)
}

if exp, got := niExp.NumberOfAttributes(), niGot.NumberOfAttributes(); exp != got {
Expand Down

0 comments on commit 9f4bf88

Please sign in to comment.