adm: Allow generation more than one SN wallet per call #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
requested review from
roman-khimov and
cthulhu-rider
as code owners
carpawell
force-pushed
the
feat/adm-inits-more-SN-wallets
branch
from
b8a5fc6 to
419ce54
Compare
|
I decided not to create an additional command. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
+ Coverage 28.49% 28.52% +0.03%
==========================================
Files 413 413
Lines 31966 32001 +35
==========================================
+ Hits 9108 9128 +20
- Misses 22078 22091 +13
- Partials 780 782 +2 ☔ View full report in Codecov by Sentry. |
Add `wallets-number` flag that "duplicates" requests to the `neofs-adm`. Passwords and labels are the same for all the wallets being created. Names differ with the suffix-numbers. Closes #2425. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
feat/adm-inits-more-SN-wallets
branch
from
419ce54 to
d41d7a7
Compare
roman-khimov
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
wallets-numberflag that "duplicates" requests to theneofs-adm. Passwords and labels are the same for all the wallets being created. Names differ with the suffix-numbers.