deploy: Fix witnesses for Balance and Container contract deployments #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2695 +/- ##
==========================================
- Coverage 28.48% 28.45% -0.03%
==========================================
Files 413 413
Lines 31966 31997 +31
==========================================
Hits 9106 9106
- Misses 22079 22110 +31
Partials 781 781 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
bugfix/deploy-balance-container
branch
from
673b21b to
daa6344
Compare
cthulhu-rider
force-pushed
the
bugfix/deploy-balance-container
branch
from
daa6344 to
88ec5a3
Compare
To deploy these contracts in `@v0.19.1` revision: - both must be witnessed by the Alphabet (2/3n+1) to call Netmap - Container must be also witnessed by the committee majority (n/2+1) to call NNS Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/deploy-balance-container
branch
from
88ec5a3 to
2469ea8
Compare
roman-khimov
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested with 1/4/7 node envs