ir: Do not create new notary requests for SN netmap entrances #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
force-pushed
the
fix/spawning-useless-notary-request-for-bootstrap
branch
from
4eee5b0 to
5d26195
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2717 +/- ##
==========================================
- Coverage 28.78% 28.78% -0.01%
==========================================
Files 415 415
Lines 32388 32378 -10
==========================================
- Hits 9324 9319 -5
+ Misses 22230 22224 -6
- Partials 834 835 +1 ☔ View full report in Codecov by Sentry. |
carpawell
requested review from
roman-khimov and
cthulhu-rider
as code owners
roman-khimov
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
It certainly fixes #830. Contracts can be improved, but gradually and in a separate issue, we need to ensure only one method is called for at least a release and then we can remove the other one.
cthulhu-rider
approved these changes
Jan 15, 2024
carpawell
force-pushed
the
fix/spawning-useless-notary-request-for-bootstrap
branch
from
5d26195 to
4c77cd2
Compare
After fb13ef9, it is now possible not to create an additional notary request but to sign the original one. See also nspcc-dev/neofs-contract#324 that includes SN in a netmap with `AddPeer` netmap call only (without the formly required `AddPeerIR` call). Closes #830. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/spawning-useless-notary-request-for-bootstrap
branch
from
4c77cd2 to
511f7a2
Compare
roman-khimov
deleted the
fix/spawning-useless-notary-request-for-bootstrap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2612, nspcc-dev/neofs-contract#324. Refs #830.