neofs-adm: use registerTLD to register TLD #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
added
bug
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
It's the only way since neofs-contract 0.18.0, "register" just fails with
Error: could not perform test invocation: script failed (FAULT state) due to an error: at instruction 1794 (THROW): unhandled exception: "TLD denied"
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
fix-contract-deploy
branch
from
c3ff792 to
7df490e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2740 +/- ##
=======================================
Coverage 28.86% 28.86%
=======================================
Files 415 415
Lines 32470 32470
=======================================
Hits 9372 9372
Misses 22256 22256
Partials 842 842 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
approved these changes
Feb 13, 2024
carpawell
approved these changes
Feb 13, 2024
|
It's a quote, that's why. |
roman-khimov
added a commit
to nspcc-dev/neofs-testcases
that referenced
this pull request
Apr 19, 2024
nspcc-dev/neofs-node#2740 was fixed a long time ago. Signed-off-by: Roman Khimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the only way since neofs-contract 0.18.0, "register" just fails with