Fix neofs_node_engine_list_objects_time_bucket metric
#3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metric was called in a function that was not called anywhere because there is a similar function that is being used. Now the metric is called on the used function. Fix #3108. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3120 +/- ##
=======================================
Coverage 22.92% 22.92%
=======================================
Files 750 750
Lines 58710 58683 -27
=======================================
- Hits 13459 13456 -3
+ Misses 44310 44284 -26
- Partials 941 943 +2 ☔ View full report in Codecov by Sentry. |
I'd drop it, I don't see any use cases for it. |
Drop the function that was not called anywhere because there is a similar function `ListWithCursor` that is being used. Signed-off-by: Andrey Butusov <[email protected]>
roman-khimov
approved these changes
Feb 11, 2025
cthulhu-rider
approved these changes
Feb 12, 2025
cthulhu-rider
deleted the
3108-list_objects_time_bucket-metrics-sometimes-doesnt-tick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3108.
It seems that the function
Listis not used anywhere. Do we need it?