-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli/object: Support SearchV2 #3122
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3122 +/- ##
==========================================
- Coverage 22.95% 22.90% -0.05%
==========================================
Files 751 751
Lines 59228 59303 +75
==========================================
- Hits 13593 13585 -8
- Misses 44682 44763 +81
- Partials 953 955 +2 ☔ View full report in Codecov by Sentry. |
5028fcf
to
eb0480a
Compare
@@ -25,23 +37,44 @@ var ( | |||
Args: cobra.NoArgs, | |||
RunE: searchObject, | |||
} | |||
searchV2Cmd = &cobra.Command{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not objectSearchV2Cmd
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need in prefix, we're within object
package
eb0480a
to
c6bc8fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog conflict.
Add `searchv2` command to the `object` section. Closes #3119. Signed-off-by: Leonard Lyubich <[email protected]>
c6bc8fb
to
93f6531
Compare
No description provided.