node/metabase: Support ROOT and PHY search filters in new meta bucket #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continues 9e2e544. Closes #3116. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3124 +/- ##
=======================================
Coverage 22.93% 22.94%
=======================================
Files 750 750
Lines 58683 58698 +15
=======================================
+ Hits 13459 13467 +8
- Misses 44282 44287 +5
- Partials 942 944 +2 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Feb 12, 2025
|
|
||
| func convertFilterValue(f object.SearchFilter) (object.SearchMatchType, string) { | ||
| if attr := f.Header(); attr == object.FilterRoot || attr == object.FilterPhysical { | ||
| return object.MatchStringEqual, binPropMarker |
There was a problem hiding this comment.
Do we have a check anywhere for these restricted (per attribute) operations?
There was a problem hiding this comment.
no checks. U mean that ROOT and PHY aint used w/ other matchers?
There was a problem hiding this comment.
Yes, it should be a part of the request semantics check.
There was a problem hiding this comment.
gonna do in #3111
carpawell
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.