Fixes for merging single SearchV2 result #3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cover an empty result and various cursors cases. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, SearchV2 server calculated continuation flag incorrectly on
merging single search result incorrectly:
1. it treated empty set as to-be-continued and tried to calculate new
cursor from the merged result (*);
2. it treated non-empty set under the limit as to-be-continued which is
wrong.
The result is empty, so there is no last element. That's why the
following panic could occur:
```
panic: runtime error: index out of range [-1]
goroutine 1060 [running]:
github.com/nspcc-dev/neofs-node/pkg/services/object.(*server).processSearchRequest(0x14000224fd0, {0x102f644b0, 0x140009d6e70}, 0x1400033e980)
github.com/nspcc-dev/neofs-node/pkg/services/object/server.go:2075 +0xf34
github.com/nspcc-dev/neofs-node/pkg/services/object.(*server).SearchV2(0x14000224fd0, {0x102f644b0, 0x140009d6e70}, 0x1400033e980)
github.com/nspcc-dev/neofs-node/pkg/services/object/server.go:1918 +0x1fc
```
This fixes flag condition for single merged set. The panic occurs no more.
Fixes #3154. Refs #3058.
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3155 +/- ##
==========================================
- Coverage 23.04% 23.03% -0.01%
==========================================
Files 756 756
Lines 60202 60202
==========================================
- Hits 13871 13870 -1
Misses 45335 45335
- Partials 996 997 +1 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.