Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate object attributes #1058

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Deduplicate object attributes #1058

merged 1 commit into from
Jan 24, 2025

Conversation

smallhive
Copy link
Contributor

Closes #1054.

roman-khimov
roman-khimov reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe CreateObject() is better to accept a map (it's always there a layer above).

@smallhive smallhive force-pushed the 1054-copyobject-failure branch from 216f9d1 to c3a3535 Compare January 22, 2025 08:26
@smallhive
Copy link
Contributor Author

smallhive commented Jan 22, 2025 •
edited
Loading

And maybe CreateObject() is better to accept a map (it's always there a layer above).

This option I like, reworked

roman-khimov
roman-khimov reviewed Jan 22, 2025
View reviewed changes
@smallhive smallhive force-pushed the 1054-copyobject-failure branch from c3a3535 to f6b8e54 Compare January 22, 2025 10:47
This was referenced Jan 23, 2025
Closed
Closed
@smallhive
neofs: Deduplicate object attributes
3098b33 
Closes #1054.

Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive smallhive force-pushed the 1054-copyobject-failure branch from f6b8e54 to 3098b33 Compare January 24, 2025 07:46
@roman-khimov roman-khimov merged commit 3d3b41e into master Jan 24, 2025
18 checks passed
@roman-khimov roman-khimov deleted the 1054-copyobject-failure branch January 24, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CopyObject failure
2 participants
@smallhive @roman-khimov