Go update #46
Merged
Go update #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes no sense, checkSum() doesn't modify state in any way. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
* don't allocate useless buffers * compare using constant-time function Signed-off-by: Roman Khimov <[email protected]>
I've honestly tried reusing AppendUint64() in Sum(), but it only leads to additional allocations, so not worth the trouble. Other than that, not a lot to improve here. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Tests are perfectly fine with this kind of random data. Signed-off-by: Roman Khimov <[email protected]>
smallhive
previously approved these changes
Feb 12, 2024
Packages specified don't exist here (copy/paste problem), we can count all of things in this repo.. Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
===========================================
+ Coverage 0 47.56% +47.56%
===========================================
Files 0 10 +10
Lines 0 534 +534
===========================================
+ Hits 0 254 +254
- Misses 0 260 +260
- Partials 0 20 +20 ☔ View full report in Codecov by Sentry. |
smallhive
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.