-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic functions for library configuration [advanced version] #2190
Conversation
A simpler and updated version of #2066. See previous discussion there |
This is a new way to provide (more) configuration options in nDPI. The idea is to have a simple way to configure (most of) nDPI: only one function (`ndpi_set_config()`) to set any configuration parameters (in the present or on in the future) and this function prototype is as agnostic as possible. This way, anytime we need to add a new configuration parameter: * we don't need to add two public functions (a getter and a setter) * we don't break API/ABI compatibility of the library; even changing the parameter type (from integer to a list of integer, for example) doesn't break the compatibility. Two examples of how to extend the configuration are provided: * the ability to enable/disable the extraction of the sha1 fingerprint of the TLS certificates. * the upper limit on the number of packets per flow that will be subject to inspection
55bb688
to
81bc7d6
Compare
Remove: `ndpi_set_detection_preferences()`, `ndpi_set_opportunistic_tls()`, `ndpi_get_opportunistic_tls()`, `ndpi_set_protocol_aggressiveness()`, `ndpi_get_protocol_aggressiveness()`
Functions removed: `ndpi_get_lru_cache_size()`, `ndpi_set_lru_cache_size()`, `ndpi_set_lru_cache_ttl()` and `ndpi_get_lru_cache_ttl()`.
3c9c0e7
to
c363b4f
Compare
Keep looking for RTP packets but remove the monitoring concept. We will re-introduce a more general concept of "flow in monitoring state" later. The function was disabled by default. Some configuration knobs will be provided when/if ntop#2190 is merged.
Keep looking for RTP packets but remove the monitoring concept. We will re-introduce a more general concept of "flow in monitoring state" later. The function was disabled by default. Some configuration knobs will be provided when/if ntop#2190 is merged.
Keep looking for RTP packets but remove the monitoring concept. We will re-introduce a more general concept of "flow in monitoring state" later. The function was disabled by default. Some configuration knobs will be provided when/if #2190 is merged.
API changes Almost all nDPI configuration is made via
|
|
This is a new way to provide (more) configuration options in nDPI.
The idea is to have a simple way to configure (most of) nDPI: only one function (
ndpi_set_config()
) to set any configuration parameters (in the present or on in the future) and this function prototype is as agnostic as possible.This way, anytime we need to add a new configuration parameter:
Two examples of how to extend the configuration are provided: