Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NDPI_PROTOCOL_RPC to NDPI_PROTOCOL_MS_RPCH #2218

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Rename NDPI_PROTOCOL_RPC to NDPI_PROTOCOL_MS_RPCH #2218

merged 3 commits into from
Dec 19, 2023

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

I think it's worth renaming this protocol ID to avoid confusion: the HTTP methods RPC_IN_DATA and RPC_OUT_DATA are only used by the MS-RPCH (Microsoft RPC over HTTP) protocol. Previously this protocol ID was also used for DCE/RPC, but now there is a separate one (NDPI_PROTOCOL_DCERPC) for it.

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@IvanNardi IvanNardi merged commit 6af93c0 into ntop:dev Dec 19, 2023
33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the rename/ndpi-protocol-rpc branch December 19, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants