Add HL7 protocol dissector #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that https://github.com/virtalabs/tapirx/blob/develop/testdata/HL7-ORM.pcap the same HL7 protocol? |
Yea, it's HL7 version 2.x |
IvanNardi
requested changes
Jan 2, 2024
|
@IvanNardi Thanks for the review, I've fixed all the issues. |
0xA50C1A1
force-pushed
the
new-dissector/hl7
branch
from
613b2b7 to
09cb860
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please sign (check) the below before submitting the Pull Request:
Describe changes:
Health Level 7 Version 2.x / 3 (over HTTP only) Messaging Standard - as you can guess from the name, it's widely used in medicine. I don't have any pcap samples of HL7 over HTTP, so I was only guided by this description.