feat: Add vaccel_config bindings and update agent API
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papazof
force-pushed
the
feat_unified_config
branch
6 times, most recently
from
b9464b1 to
1fc9212
Compare
ilagomatis
approved these changes
Feb 10, 2025
Implement `vaccel_config` bindings and add wrappers for `vaccel_bootstrap*()`/`vaccel_cleanup()` functions PR: #6 Signed-off-by: Kostis Papazafeiropoulos <[email protected]> Reviewed-by: Ilias Lagomatis <[email protected]> Approved-by: Ilias Lagomatis <[email protected]>
Generate error messages in `vaccel-bindings` using the `thiserror` crate, as we do for the other crates PR: #6 Signed-off-by: Kostis Papazafeiropoulos <[email protected]> Reviewed-by: Ilias Lagomatis <[email protected]> Approved-by: Ilias Lagomatis <[email protected]>
Rework agent API to support vaccel configuration and better structure implementation. Changes for `vaccel-bindings`, `vaccel-rpc-client` and `vaccel-rpc-agent`: - Rename service struct to `AgentService` - Rename `VaccelEmpty` RPC message to `EmptyResponse` following the common scheme Changes for `vaccel-rpc-agent`: - Split `AgentService` and related common definitions to `agent_service.rs` - Move `rpc_async.rs` and `rpc_sync.rs` to `async/agent_service.rs` and `sync/agent_service.rs` respectively for consistency - Consolidate agent related functions from `lib.rs` to new `Agent` struct and split to separate `agent.rs` - Add API support for creating an `Agent` with a `vaccel_config` object and initializing vaccel with the agent configuration - Add proper `start()`/`stop()` methods for `Agent` - Add CLI support for parsing vaccel config options and split implementation to `cli.rs` - Extend and use common errors properly PR: #6 Signed-off-by: Kostis Papazafeiropoulos <[email protected]> Reviewed-by: Ilias Lagomatis <[email protected]> Approved-by: Ilias Lagomatis <[email protected]>
Fix link for vaccel binary in `README.md` PR: #6 Signed-off-by: Kostis Papazafeiropoulos <[email protected]> Reviewed-by: Ilias Lagomatis <[email protected]> Approved-by: Ilias Lagomatis <[email protected]>
Add temporary install step for missing libcurl/libstb and ensure all features are checked separately PR: #6 Signed-off-by: Kostis Papazafeiropoulos <[email protected]> Reviewed-by: Ilias Lagomatis <[email protected]> Approved-by: Ilias Lagomatis <[email protected]>
github-actions
bot
force-pushed
the
feat_unified_config
branch
from
1fc9212 to
844f893
Compare
papazof
added a commit
that referenced
this pull request
Feb 10, 2025
Implement `vaccel_config` bindings and add wrappers for `vaccel_bootstrap*()`/`vaccel_cleanup()` functions PR: #6 Signed-off-by: Kostis Papazafeiropoulos <[email protected]> Reviewed-by: Ilias Lagomatis <[email protected]> Approved-by: Ilias Lagomatis <[email protected]>
papazof
added a commit
that referenced
this pull request
Feb 10, 2025
Generate error messages in `vaccel-bindings` using the `thiserror` crate, as we do for the other crates PR: #6 Signed-off-by: Kostis Papazafeiropoulos <[email protected]> Reviewed-by: Ilias Lagomatis <[email protected]> Approved-by: Ilias Lagomatis <[email protected]>
papazof
added a commit
that referenced
this pull request
Feb 10, 2025
Rework agent API to support vaccel configuration and better structure implementation. Changes for `vaccel-bindings`, `vaccel-rpc-client` and `vaccel-rpc-agent`: - Rename service struct to `AgentService` - Rename `VaccelEmpty` RPC message to `EmptyResponse` following the common scheme Changes for `vaccel-rpc-agent`: - Split `AgentService` and related common definitions to `agent_service.rs` - Move `rpc_async.rs` and `rpc_sync.rs` to `async/agent_service.rs` and `sync/agent_service.rs` respectively for consistency - Consolidate agent related functions from `lib.rs` to new `Agent` struct and split to separate `agent.rs` - Add API support for creating an `Agent` with a `vaccel_config` object and initializing vaccel with the agent configuration - Add proper `start()`/`stop()` methods for `Agent` - Add CLI support for parsing vaccel config options and split implementation to `cli.rs` - Extend and use common errors properly PR: #6 Signed-off-by: Kostis Papazafeiropoulos <[email protected]> Reviewed-by: Ilias Lagomatis <[email protected]> Approved-by: Ilias Lagomatis <[email protected]>
papazof
added a commit
that referenced
this pull request
Feb 10, 2025
Fix link for vaccel binary in `README.md` PR: #6 Signed-off-by: Kostis Papazafeiropoulos <[email protected]> Reviewed-by: Ilias Lagomatis <[email protected]> Approved-by: Ilias Lagomatis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
vaccel_configbindings and rework agent API to support vaccel configuration.Noteworthy changes:
vaccel_configbindings and add wrappers forvaccel_bootstrap*()/vaccel_cleanup()functionslib.rsto newAgentstruct and split to separateagent.rsAgentwith avaccel_configobject and initializing vaccel with the agent configurationcli.rs