Skip to content

fix(glow): escaping line start#420

Merged
tipiirai merged 1 commit intonuejs:masterfrom
nobkd:fix-nuemark/code-block-escapes
Dec 13, 2024
Merged

fix(glow): escaping line start#420
tipiirai merged 1 commit intonuejs:masterfrom
nobkd:fix-nuemark/code-block-escapes

Conversation

@nobkd
Copy link
Collaborator

@nobkd nobkd commented Dec 13, 2024

Sorry, seems I wrongly added a not operator there.. (see L250)

Fix for first part of #379 (comment).


Additional changes:

  • fixed naming of mark replacement function

Off topic:
Using more than 3 backticks on both code block ends still does not work. That would be part of nuemark. (The end of the fenced code block can have more characters than the start, but must have at least as many as the start (per CommonMark iirc))

Sorry, seems I wrongly added a `not` there..
@nobkd nobkd requested a review from tipiirai December 13, 2024 00:52
@nobkd nobkd mentioned this pull request Dec 13, 2024
@tipiirai tipiirai merged commit c599879 into nuejs:master Dec 13, 2024
4 checks passed
@nobkd nobkd deleted the fix-nuemark/code-block-escapes branch December 13, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants