Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clover Viewer bug (temporarily) #3720

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

adamjarling
Copy link
Contributor

@adamjarling adamjarling commented Dec 11, 2023

Summary

To fix a bug where Clover Viewer no longer renders OpenSeadragon successfully, this PR pins Clover to a previous version so the Viewer will render OSD successfully. Also, this remove the previous viewer dependency, and OpenSeadragon as a direct dependency since they're no longer used.

Opening a new issue to diagnose where things break in Meadow, and how to get Meadow back to using the latest version...

https://github.com/nulib/repodev_planning_and_docs/issues/new

Version bump required by the PR

See Semantic Versioning 2.0.0 for help discerning which is required.

  • Patch
  • Minor
  • Major

Steps to Test

Please let end users know what they need to do to test on staging or production

Also please let developers know if there are any special instructions to test this in the development environment.

🚀 Deployment Notes

Note - if you check any of these boxes go to the (always open) main <- staging PR and add detailed notes and instructions to help out others who may end up deploying your changes to production

  • Backward compatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Backwards-incompatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Requires data migration
  • Requires database triggers disabled during deployment/migration
  • Requires reindex
  • Terraform changes
    • Adds/requires new or changed Terraform variables
  • Pipeline configuration changes (requires mix meadow.pipeline.setup run)
  • Requires new variable added to miscellany
  • Specific deployment synchronization instructions with other apps/API's
  • Other specific instructions/tasks

Tested/Verified

  • End users/stakeholders

…sfully. Remove previous viewer dependencies, and OpenSeadragon direct dependency
@adamjarling adamjarling requested a review from mbklein December 11, 2023 21:55
@adamjarling adamjarling self-assigned this Dec 11, 2023
@adamjarling adamjarling merged commit 08df0c0 into deploy/staging Dec 11, 2023
4 checks passed
@adamjarling adamjarling deleted the bug-clover-fix branch December 11, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants