Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safari bug when adding a new Work FileSet by dragging into the dropzone #3765

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

adamjarling
Copy link
Contributor

@adamjarling adamjarling commented Jan 9, 2024

Summary

This fixes a Safari bug when selecting a new FileSet for a Work on the Preservation tab, the FileSet Role form field (though selected) was not passing form validation. It only happened when a file was dragged into the form file select drop zone for some reason...

image

Specific Changes in this PR

  • Update how we calculate the required attribute on FileSet Role select

Version bump required by the PR

See Semantic Versioning 2.0.0 for help discerning which is required.

  • Patch
  • Minor
  • Major

Steps to Test

In a Safari browser, navigate to a Work page, Preservation tab, and add a new "Preservation" Role Fileset file.

  • Verify it works dragging a file into the drop zone
  • Verify it works manually selecting a file by clicking in the drop zone first

Also please let developers know if there are any special instructions to test this in the development environment.

🚀 Deployment Notes

Note - if you check any of these boxes go to the (always open) main <- staging PR and add detailed notes and instructions to help out others who may end up deploying your changes to production

  • Backward compatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Backwards-incompatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Requires data migration
  • Requires database triggers disabled during deployment/migration
  • Requires reindex
  • Terraform changes
    • Adds/requires new or changed Terraform variables
  • Pipeline configuration changes (requires mix meadow.pipeline.setup run)
  • Requires new variable added to miscellany
  • Specific deployment synchronization instructions with other apps/API's
  • Other specific instructions/tasks

Tested/Verified

  • End users/stakeholders

@adamjarling adamjarling self-assigned this Jan 9, 2024
Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and simple fix. Works well for me.

@adamjarling adamjarling merged commit 0949368 into deploy/staging Jan 12, 2024
4 checks passed
@adamjarling adamjarling deleted the 3038-safari-fileset-attach-bug branch January 12, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants