Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honor lookbackSeconds in monovertex and rust pipeline #2258

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

kohlisid
Copy link
Contributor

@kohlisid kohlisid commented Dec 5, 2024

Currently if the lookbackSeconds is specified in the spec, the metric lag reader does not honor that value and keeps using default

apiVersion: numaflow.numaproj.io/v1alpha1
kind: MonoVertex
metadata:
  name: simple-mono-vertex
spec:
  scale:
    lookbackSeconds: 90

Before change

skohli@macos-JQWR9T560R numaflow % kubectl logs simple-mono-vertex-mv-0-fovym -f | grep MYDEBUG
2024-12-05T01:01:55.057650Z  INFO numaflow_core::metrics: MYDEBUG LABEL "default" 120
2024-12-05T01:02:04.057950Z  INFO numaflow_core::metrics: MYDEBUG LABEL "default" 120

After


skohli@macos-JQWR9T560R numaflow % kubectl logs simple-mono-vertex-mv-0-pfevp -f | grep MYDEBUG
2024-12-05T01:02:55.514563Z  INFO numaflow_core::metrics: MYDEBUG LABEL "default" 90
2024-12-05T01:02:58.514440Z  INFO numaflow_core::metrics: MYDEBUG LABEL "default" 90

Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
tests
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.73%. Comparing base (05df886) to head (02cf4b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2258      +/-   ##
==========================================
- Coverage   64.75%   64.73%   -0.03%     
==========================================
  Files         345      345              
  Lines       41415    41465      +50     
==========================================
+ Hits        26819    26843      +24     
- Misses      13528    13554      +26     
  Partials     1068     1068              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clean
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
@vigith vigith marked this pull request as ready for review December 5, 2024 03:37
@vigith vigith requested a review from whynowy as a code owner December 5, 2024 03:37
clean
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
@kohlisid kohlisid merged commit 5c9094b into numaproj:main Dec 5, 2024
25 checks passed
@kohlisid kohlisid deleted the mvtx-look branch December 5, 2024 08:03
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
…2258)

Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
kohlisid added a commit that referenced this pull request Feb 19, 2025
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants