Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import v1 of FastGaussQuadrature.jl #50

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

hsugawa8651
Copy link
Contributor

No description provided.

@hsugawa8651
Copy link
Contributor Author

hsugawa8651 commented Mar 11, 2025

Thank you for accepting my PR, though I missed that all the checks failed.
We will pass the checks if we do the following.

I also find that Julia version should be 1.6 or higher from the requirement of FastGaussQuadrature.jl.

I would like to revise my branch.

@hsugawa8651
Copy link
Contributor Author

I revised my branch to include Julia version 1.6 and docstrings of the BaryChebTools module.

However, I cannot handle the depreciated cache package problem because I do not have permission to update .github/workflows/CI.yml.
Could you please modify the line of 26th of CI.yml from actions/cache@v1 to actions/cache@v4 ?
Then, I will prepare my branch as diffs to the latest master's.

@iintSjds
Copy link
Member

I revised my branch to include Julia version 1.6 and docstrings of the BaryChebTools module.

However, I cannot handle the depreciated cache package problem because I do not have permission to update .github/workflows/CI.yml. Could you please modify the line of 26th of CI.yml from actions/cache@v1 to actions/cache@v4 ? Then, I will prepare my branch as diffs to the latest master's.

I've updated the master branch. Please go ahead.

@hsugawa8651
Copy link
Contributor Author

hsugawa8651 commented Mar 12, 2025

I prepared my fix branch. Please check and approve a merge.

@iintSjds iintSjds merged commit 6dee613 into numericalEFT:master Mar 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants