-
-
Notifications
You must be signed in to change notification settings - Fork 85
TYP: Inline typing annotations #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jorenham
wants to merge
13
commits into
numpy:main
Choose a base branch
from
jorenham:typing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+463
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for including this, @jorenham it looks like great progress. I'm going to be busy this week, however I'll try to review it next weekend in depth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intentionally annotated the input types to (also) accept the overly-loose
numpy.typing.ArrayLike
type. Because even though that also accepts invalid input, it would avoid breaking user code likewhich I'm guessing is the primary use-case of
numpy_financial
(or maybe that was just me).Anyway, there's still quite a bit of room for improvement. For example, by making
mypy
andpyright
pass is strict mode. But getting there wll take quite a bit of effort for diminishing returns.Closes #133