Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Pin gym[atari] version #112

Merged
merged 4 commits into from
Nov 30, 2021
Merged

MAINT: Pin gym[atari] version #112

merged 4 commits into from
Nov 30, 2021

Conversation

melissawm
Copy link
Member

@melissawm melissawm commented Nov 30, 2021

This fixes CI but doesn't totally get all of #87 yet.

@melissawm melissawm marked this pull request as draft November 30, 2021 19:44
@melissawm melissawm force-pushed the fix-atari-py branch 2 times, most recently from fe2aaf2 to 93ad2e2 Compare November 30, 2021 21:35
@rossbar
Copy link
Collaborator

rossbar commented Nov 30, 2021

FTR this shouldn't have any affect on the CI, since the workflow uses pip (i.e. requirements files) rather than conda. +1 for the change though as we need to keep requirements.txt and environment.yml in sync (a bot that did this automatically would be great!)

The CI failures are related to failing to grab some Debian packages required to build the atari-py wheel locally. Maybe try adding sudo apt-get update prior to the line that apt-get's cmake and ffmpeg?

@melissawm
Copy link
Member Author

Ah - we were having a failing run on CI because atari-py (or gym) couldn't fetch the rom with the new version, but this other failure is also weird. Let me do that.

@melissawm melissawm force-pushed the fix-atari-py branch 2 times, most recently from b8a74d0 to 53aa0a0 Compare November 30, 2021 21:49
@melissawm
Copy link
Member Author

melissawm commented Nov 30, 2021

Ok - I see this warning on CircleCI: https://circleci.com/docs/2.0/circleci-images/

Legacy images with the prefix "circleci/" will be deprecated on December 31, 2021. For faster builds, upgrade your projects with next-generation convenience images

It might be worth just updating to the new cimg/python:3.8 image instead?

@rossbar
Copy link
Collaborator

rossbar commented Nov 30, 2021

Yeah definitely, though that will also probably necessitate even more apt-get-ing because IIRC the python images are stripped down to the bare minimum needed to support Python.

We need to do it anyways so +1 for doing it here.

@melissawm
Copy link
Member Author

It works! 🎉

@melissawm melissawm marked this pull request as ready for review November 30, 2021 22:12
Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for chasing down the right recipe @melissawm !

It'd be great to tear out all the build-our-own-wheels stuff eventually, but we'll have to tackle #87 to get there

@rossbar rossbar merged commit 7c7e97a into numpy:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants