-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Pin gym[atari] version #112
Conversation
fe2aaf2
to
93ad2e2
Compare
FTR this shouldn't have any affect on the CI, since the workflow uses The CI failures are related to failing to grab some Debian packages required to build the atari-py wheel locally. Maybe try adding |
93ad2e2
to
240e7d8
Compare
Ah - we were having a failing run on CI because atari-py (or gym) couldn't fetch the rom with the new version, but this other failure is also weird. Let me do that. |
b8a74d0
to
53aa0a0
Compare
53aa0a0
to
93d5635
Compare
Ok - I see this warning on CircleCI: https://circleci.com/docs/2.0/circleci-images/ Legacy images with the prefix "circleci/" will be deprecated on December 31, 2021. For faster builds, upgrade your projects with next-generation convenience images It might be worth just updating to the new |
Yeah definitely, though that will also probably necessitate even more We need to do it anyways so +1 for doing it here. |
It works! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for chasing down the right recipe @melissawm !
It'd be great to tear out all the build-our-own-wheels stuff eventually, but we'll have to tackle #87 to get there
This fixes CI but doesn't totally get all of #87 yet.