Skip to content

✨ enable reportImplicitOverride #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

✨ enable reportImplicitOverride #311

merged 1 commit into from
Mar 14, 2025

Conversation

guan404ming
Copy link
Member

@guan404ming guan404ming commented Mar 13, 2025 •
edited
Loading

@guan404ming guan404ming changed the title ✨ feat: turn on reportImplicitOverride ✨ feat: enable reportImplicitOverride Mar 13, 2025
@guan404ming guan404ming changed the title ✨ feat: enable reportImplicitOverride ✨ enable reportImplicitOverride Mar 13, 2025
@guan404ming guan404ming changed the title ✨ enable reportImplicitOverride ✨ enable reportImplicitOverride Mar 13, 2025
@jorenham jorenham added this to the v2.2.x.0 milestone Mar 13, 2025
@jorenham jorenham marked this pull request as draft March 13, 2025 19:28
@guan404ming guan404ming force-pushed the enable-reportImplicitOverride-in-pyproject branch from bab42dc to b543417 Compare March 14, 2025 15:39
@guan404ming guan404ming marked this pull request as ready for review March 14, 2025 15:42
@guan404ming
Copy link
Member Author

@jorenham Hi, please help review, thanks!

@jorenham
Copy link
Member

The diff is a bit weird, and includes #317. Maybe rebase on main again?

@guan404ming guan404ming force-pushed the enable-reportImplicitOverride-in-pyproject branch from b543417 to 3aae687 Compare March 14, 2025 15:53
@guan404ming
Copy link
Member Author

Updated~

@jorenham jorenham merged commit d6cd252 into numpy:main Mar 14, 2025
21 checks passed
@jorenham
Copy link
Member

Thanks Guan-Ming

@guan404ming guan404ming deleted the enable-reportImplicitOverride-in-pyproject branch March 14, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham jorenham approved these changes

Assignees
No one assigned
Labels
tool: basedpyright
Projects
None yet
Milestone
v2.2.x.0
Development

Successfully merging this pull request may close these issues.

fix all reportImplicitOverride errors
2 participants
@guan404ming @jorenham