Skip to content

fix(i18n): missing keys and hardcoded translation prompt #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2024
Merged

fix(i18n): missing keys and hardcoded translation prompt #1963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
303e39d
fix(i18n): translate translation page
mrskycriper Mar 24, 2024
ab059d7
fix(i18n): add missing keys
mrskycriper Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/settings-page/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,11 @@ export class SettingsPage extends Component<
}
}
renderTranslate(): JSX.Element {
const { t } = this.props;
return (
<div className="p-3">
<p>
You can help with the translation at{' '}
{t('settings:translation_prompt')}{' '}
<a
target="_blank"
rel="noopener noreferrer"
Expand Down
7 changes: 6 additions & 1 deletion src/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2602,7 +2602,12 @@
"coordinator_ieee_address": "Coordinator IEEE Address",
"request_z2m_backup": "Request Z2m backup",
"add_install_code": "Add install code",
"homeassistant": "Home Assistant integration"
"enter_install_code": "Enter install code",
"homeassistant": "Home Assistant integration",
"translation_prompt": "You can help with the translation at",
"zigbee_herdsman_converters_version": "zigbee-herdsman-converters version",
"zigbee_herdsman_version": "zigbee-herdsman version",
"localise_images": "Localise device images"
},
"touchlink": {
"detected_devices_message": "Detected {{count}} touchlink devices.",
Expand Down