Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W7.7][T10-B1] AcquaiNote #70

Open
wants to merge 447 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
447 commits
Select commit Hold shift + click to select a range
d5c276e
Merge pull request #59 from qihao27/master
Hailinx Oct 29, 2017
c8699f6
Edit build.gradle fro building jar file
Hailinx Oct 29, 2017
865e823
Enhance Select command
Hailinx Oct 29, 2017
a536a2b
Update code style
Hailinx Oct 29, 2017
d004ecd
Merge branch 'master' into master
Hailinx Oct 29, 2017
8f7ec4b
Add export command
qihao27 Oct 30, 2017
265e2fa
Add Junit Test
qihao27 Oct 31, 2017
ea8c7de
Merge branch 'master' into master
qihao27 Oct 31, 2017
d1e18ff
Update ExportCommandTest.java
qihao27 Oct 31, 2017
9dc41eb
Update ExportCommandParserTest.java
qihao27 Oct 31, 2017
ea73f3b
Merge pull request #63 from qihao27/master
Hailinx Nov 1, 2017
d79ca10
Update docs: update roles, README, sort implementation
qihao27 Nov 1, 2017
463cf95
Merge branch 'master' of https://github.com/qihao27/addressbook-level4
qihao27 Nov 1, 2017
9e2ed9b
Merge branch 'master' into master
qihao27 Nov 1, 2017
ae823b0
Add collate comment
qihao27 Nov 1, 2017
937b22b
Rectify style issue
qihao27 Nov 1, 2017
d565ce9
Todo command
Hailinx Nov 1, 2017
358947e
Change getTodoItem() to return a unmodifiableList
Hailinx Nov 1, 2017
c6ca876
Fix the bug: when "undo", UI is not updated.
Hailinx Nov 1, 2017
9138485
Add constraints when constructing TodoItem class
Hailinx Nov 1, 2017
351852e
Merge pull request #64 from qihao27/master
Hailinx Nov 1, 2017
64ab6bf
Add new command "switch"
Hailinx Nov 1, 2017
47714d6
Implement new command "switch"
Hailinx Nov 1, 2017
f2f428d
Merge branch 'master' into master
Hailinx Nov 1, 2017
0f3a3b6
Update annotations and codestyle
Hailinx Nov 1, 2017
083aede
Merge branch 'master' of https://github.com/Hailinx/addressbook-level4
Hailinx Nov 1, 2017
b8e6e67
Merge branch 'master' into master
Hailinx Nov 1, 2017
6c8820c
Merge branch 'master' into master
Hailinx Nov 1, 2017
5571bcc
Delete trailing whitespace
Hailinx Nov 1, 2017
c1ace68
Modify codestyle
Hailinx Nov 1, 2017
f130625
Update SelectCommandSystemTest.java
Hailinx Nov 1, 2017
0a86db5
Merge pull request #60 from Hailinx/master
qihao27 Nov 1, 2017
5b3055c
Added JUnit tests for FavouriteCommand
aaronyhsoh Nov 1, 2017
29efbf8
Merge branch 'master' of https://github.com/aaronyhsoh/addressbook-le…
aaronyhsoh Nov 1, 2017
a2679e8
Collating
aaronyhsoh Nov 1, 2017
055d0c9
Merge branch 'master' into master
aaronyhsoh Nov 1, 2017
3065fa1
Merge branch 'master' into master
aaronyhsoh Nov 1, 2017
2311676
Update AddressBookParser.java
aaronyhsoh Nov 1, 2017
e3c12b8
Rectifying Travis CI build fail
aaronyhsoh Nov 1, 2017
f4a52f5
Merge branch 'master' of https://github.com/aaronyhsoh/addressbook-le…
aaronyhsoh Nov 1, 2017
d66d6f9
Merge pull request #6 from CS2103AUG2017-T10-B1/master
Hailinx Nov 1, 2017
054d974
Add collate comments
Hailinx Nov 1, 2017
0746e70
Creates .md file after adding collate comments
Hailinx Nov 1, 2017
ca022d6
collate
aaronyhsoh Nov 1, 2017
a423705
rectify checkstyle errors
aaronyhsoh Nov 1, 2017
75c32f0
Merge pull request #57 from aaronyhsoh/master
Hailinx Nov 1, 2017
73b3609
Merge pull request #7 from CS2103AUG2017-T10-B1/master
Hailinx Nov 1, 2017
1a67d1c
Update code style
Hailinx Nov 1, 2017
539c3f0
Merge pull request #68 from Hailinx/master
qihao27 Nov 2, 2017
0bb0164
Merge pull request #2 from CS2103AUG2017-T10-B1/master
qihao27 Nov 2, 2017
22bb411
Change favourite person visual effect
qihao27 Nov 2, 2017
e34e914
Update Junit test for "todo" and "switch" command
Hailinx Nov 2, 2017
11cf879
Merge pull request #69 from qihao27/master
Hailinx Nov 2, 2017
b5cdcdf
Merge branch 'master' into master
Hailinx Nov 2, 2017
d01fd28
Merge pull request #70 from Hailinx/master
qihao27 Nov 2, 2017
8409377
Update user guide
Hailinx Nov 3, 2017
2772f12
Merge branch 'master' of https://github.com/Hailinx/addressbook-level4
Hailinx Nov 3, 2017
30192ec
Update collate
Hailinx Nov 3, 2017
fb00e9e
Merge branch 'master' into master
Hailinx Nov 3, 2017
c6d9e57
Merge pull request #73 from Hailinx/master
qihao27 Nov 3, 2017
679d589
Merge pull request #8 from CS2103AUG2017-T10-B1/master
Hailinx Nov 3, 2017
79c8170
Bug fix on export command
qihao27 Nov 4, 2017
095d6a0
Merge branch 'master' into master
qihao27 Nov 4, 2017
87be695
Merge pull request #77 from qihao27/master
Hailinx Nov 6, 2017
ae12738
Update collate comments
qihao27 Nov 6, 2017
0120f37
Added todo list count in person card
qihao27 Nov 6, 2017
13c52bd
Resolving conflict
qihao27 Nov 6, 2017
42a8a07
Rectify style issue
qihao27 Nov 6, 2017
2e7e048
Merge branch 'master' into master
qihao27 Nov 6, 2017
7f3dcb9
Update Junit test and collate comments
qihao27 Nov 6, 2017
07547de
Merge branch 'master' of https://github.com/qihao27/addressbook-level4
qihao27 Nov 6, 2017
fa426e3
Improve test coverage
qihao27 Nov 7, 2017
e43b6ab
Rectified bug in FavouriteCommand
aaronyhsoh Nov 7, 2017
8060012
Rectify style issue
qihao27 Nov 7, 2017
dba6ce9
Change app name
qihao27 Nov 7, 2017
3c4fc2a
Fix two bugs
Hailinx Nov 7, 2017
69e73cf
Merge branch 'master' into master
Hailinx Nov 7, 2017
c01104a
Update code style
Hailinx Nov 7, 2017
02729f7
Merge branch 'master' of https://github.com/Hailinx/addressbook-level4
Hailinx Nov 7, 2017
ad30a28
update collates and modify errors in test cases
Hailinx Nov 7, 2017
813fea5
Attemp to increase test coverage
qihao27 Nov 7, 2017
286057a
Attemp to inprove test coverage and codacy
qihao27 Nov 7, 2017
8059b85
Update JUnit tests for UI "TodoCard" and "TodoPanel"
Hailinx Nov 7, 2017
73fd6f7
Update code quality
Hailinx Nov 7, 2017
1923d0f
Add test file: UniqueTodoListTest.java
qihao27 Nov 7, 2017
95b7586
Update code quality
Hailinx Nov 7, 2017
4209401
update code quality
Hailinx Nov 7, 2017
3a94973
Update Developer Guide for "todo" and "select" command
Hailinx Nov 8, 2017
17610aa
Merge pull request #79 from Hailinx/master
Hailinx Nov 8, 2017
cdfd876
Update UniqueTodoList and its coverage
qihao27 Nov 8, 2017
c44af62
Merge branch 'master' into master
qihao27 Nov 8, 2017
765f46d
Resolve conflict
qihao27 Nov 8, 2017
dd181be
Merge branch 'master' into master
Hailinx Nov 8, 2017
39d3505
Merge branch 'master' of https://github.com/qihao27/addressbook-level4
qihao27 Nov 8, 2017
c03228e
Update collate
qihao27 Nov 8, 2017
e2bea7d
Rectify style issue
qihao27 Nov 8, 2017
95d0ff9
Add Project Portfolio
Hailinx Nov 8, 2017
d34049b
Merge branch 'master' into master
Hailinx Nov 8, 2017
0bb4f95
Merge pull request #78 from qihao27/master
qihao27 Nov 8, 2017
5635f40
Merge branch 'master' into master
Hailinx Nov 8, 2017
e23bf7f
Enhanced Undo command
aaronyhsoh Nov 8, 2017
1eca771
Enhanced Redo Command
aaronyhsoh Nov 8, 2017
a30defe
Updated user guide
aaronyhsoh Nov 8, 2017
3e7d80a
Merge pull request #81 from Hailinx/master
aaronyhsoh Nov 8, 2017
f165170
Changed tag colour
aaronyhsoh Nov 8, 2017
9a85034
Collated code
aaronyhsoh Nov 8, 2017
997a19a
update developr guide
aaronyhsoh Nov 8, 2017
742430e
Update developer guide
aaronyhsoh Nov 8, 2017
79de445
Update DeveloperGuide.adoc
aaronyhsoh Nov 8, 2017
de6e7e2
Add sequence diagram for favourite command
aaronyhsoh Nov 8, 2017
5a57a09
Added sequence diagram to developer guide
aaronyhsoh Nov 8, 2017
45cd09e
Merge pull request #3 from CS2103AUG2017-T10-B1/master
qihao27 Nov 8, 2017
d380077
Add PPP
qihao27 Nov 8, 2017
c687637
Resolve conflict
qihao27 Nov 8, 2017
3a1ee4c
Merge pull request #84 from qihao27/master
Hailinx Nov 8, 2017
83ff68e
Added project portfolio
aaronyhsoh Nov 8, 2017
cafe957
Rename Aaron Soh to AaronSoh.adoc
aaronyhsoh Nov 8, 2017
66b0790
Rectified checkstyle errors
aaronyhsoh Nov 8, 2017
ce294d0
Merge branch 'master' of https://github.com/aaronyhsoh/addressbook-le…
aaronyhsoh Nov 8, 2017
ffa8d3c
Merge branch 'master' into master
aaronyhsoh Nov 8, 2017
6ed9967
Merge branch 'master' into master
aaronyhsoh Nov 8, 2017
234bd87
Rectifying travis error
aaronyhsoh Nov 8, 2017
4bb4009
rectify travis
aaronyhsoh Nov 8, 2017
298be3d
Merge pull request #85 from aaronyhsoh/master
Hailinx Nov 9, 2017
3b3140b
Merge pull request #9 from CS2103AUG2017-T10-B1/master
Hailinx Nov 9, 2017
b4a4f21
recollate the whole project
Hailinx Nov 9, 2017
3d7f024
Merge pull request #86 from Hailinx/master
Hailinx Nov 9, 2017
d639625
Merge pull request #1 from CS2103AUG2017-T10-B1/master
aaronyhsoh Nov 9, 2017
0fd0432
change the position of fav star
Hailinx Nov 9, 2017
81825ba
Small changes to result display and icon position
qihao27 Nov 9, 2017
7c65478
Update sort command: small changes to result display
qihao27 Nov 9, 2017
7038851
Refine DeleteByName command
qihao27 Nov 9, 2017
113db10
Update app status URL in README
qihao27 Nov 9, 2017
87b2147
Merge branch 'master' into master
qihao27 Nov 9, 2017
819a1eb
Merge branch 'master' into master
qihao27 Nov 9, 2017
00d43b5
Update DeleteByNameCommand.java
qihao27 Nov 9, 2017
5704e3d
Update DeleteByNameCommandParser.java
qihao27 Nov 9, 2017
82285ff
Update DeleteByNameCommandTest.java
qihao27 Nov 9, 2017
f233816
Update ParserUtilTest.java
qihao27 Nov 9, 2017
e75051b
Improve coverage
qihao27 Nov 10, 2017
abdc83d
Merge branch 'master' of https://github.com/qihao27/addressbook-level4
qihao27 Nov 10, 2017
195c1c2
Rectify style issue
qihao27 Nov 10, 2017
43bb9ed
Merge pull request #93 from qihao27/master
Hailinx Nov 10, 2017
9a79839
Added switch buttons
qihao27 Nov 10, 2017
6786e46
Merge branch 'master' into master
qihao27 Nov 10, 2017
26202e4
Update PersonListCard.fxml
qihao27 Nov 10, 2017
b7c5907
Update PersonListCard.fxml
qihao27 Nov 10, 2017
5b946e0
fix the bug when delete a todo item the index may be out of boundary
Hailinx Nov 11, 2017
379b3a0
fix the bug when "lock" or "unlock", the ui will be resized
Hailinx Nov 11, 2017
bccb45b
fix the bug after locking, users cannot use "exit" command
Hailinx Nov 11, 2017
be257ae
Merge branch 'master' into master
Hailinx Nov 11, 2017
0ff8a2e
Merge branch 'master' into master
Hailinx Nov 11, 2017
7158e31
Update PersonListCard.fxml
qihao27 Nov 11, 2017
6f76247
add systemtest for find command
Hailinx Nov 11, 2017
d52e195
Enhance DeleteByName command and its test
qihao27 Nov 11, 2017
15b6d34
Conflict issue
qihao27 Nov 11, 2017
a2b765d
Merge branch 'master' of https://github.com/Hailinx/addressbook-level4
Hailinx Nov 11, 2017
227ca42
Improve code quality
qihao27 Nov 11, 2017
8bf6fab
Improve code
qihao27 Nov 11, 2017
f722aea
improve junit test and code style
Hailinx Nov 12, 2017
b9c9cca
Merge pull request #99 from Hailinx/master
qihao27 Nov 12, 2017
f900783
Merge branch 'master' into master
qihao27 Nov 12, 2017
0a0c835
Merge branch 'master' into master
qihao27 Nov 12, 2017
97a7125
Merge pull request #101 from qihao27/master
Hailinx Nov 12, 2017
8a7c0ab
Merge pull request #4 from CS2103AUG2017-T10-B1/master
qihao27 Nov 12, 2017
9b16917
Update screenshot and minor changes in favouriteStar position
qihao27 Nov 12, 2017
679294b
Merge pull request #102 from qihao27/master
Hailinx Nov 12, 2017
0a331d2
Merge pull request #10 from CS2103AUG2017-T10-B1/master
Hailinx Nov 12, 2017
9b83e6b
Update collate
qihao27 Nov 12, 2017
48bd902
Update docs
qihao27 Nov 12, 2017
6fe70f4
Merge branch 'master' into master
qihao27 Nov 12, 2017
f48d0cb
Update DG
aaronyhsoh Nov 12, 2017
047a198
Update code quality
Hailinx Nov 12, 2017
7b92e56
Update collate
Hailinx Nov 12, 2017
78a98fb
Update code
Hailinx Nov 12, 2017
2fbdd84
Edit comment
Hailinx Nov 12, 2017
c87613e
Update code style
Hailinx Nov 12, 2017
5e33b7a
Add JUnit test for new changes
Hailinx Nov 12, 2017
59af94f
Add SampleData and TestScript template.
Hailinx Nov 12, 2017
38b611d
Update code
Hailinx Nov 12, 2017
fea187d
update quality
Hailinx Nov 12, 2017
d5ba22b
Update code
Hailinx Nov 12, 2017
3906e4b
Edit comment
Hailinx Nov 12, 2017
2897709
Edit comment
Hailinx Nov 12, 2017
cc4f6d6
update code
Hailinx Nov 12, 2017
a1f0a89
edit comment
Hailinx Nov 12, 2017
4b1d20d
Add comment
Hailinx Nov 13, 2017
f81cd4b
add @Ignore otherwise, there is error: seedu.address.ui.BrowserPanelT…
Hailinx Nov 13, 2017
4a90f2a
ignore assertEquals(MainApp.class.getResource(FXML_FILE_FOLDER + DEFA…
Hailinx Nov 13, 2017
b4560d8
improve import
Hailinx Nov 13, 2017
4731513
improve import
Hailinx Nov 13, 2017
293ed33
optimise indentation
Hailinx Nov 13, 2017
824361d
optimse style
Hailinx Nov 13, 2017
e9ac256
Remove space in PPP file name
qihao27 Nov 13, 2017
501f8d6
Merge branch 'master' of https://github.com/qihao27/addressbook-level4
qihao27 Nov 13, 2017
7b46a4a
Update test
Hailinx Nov 13, 2017
a276675
Added new line at EOF
qihao27 Nov 13, 2017
121b2bb
Update test case
Hailinx Nov 13, 2017
ee1694b
Merge pull request #116 from Hailinx/master
Hailinx Nov 13, 2017
9f3b72f
Merge branch 'master' into master
Hailinx Nov 13, 2017
afe0b6a
fix the bug when clear, todo list will not be clear
Hailinx Nov 13, 2017
18c3565
Merge pull request #117 from qihao27/master
Hailinx Nov 13, 2017
8ec7f9b
Merge branch 'master' into master
Hailinx Nov 13, 2017
6507460
Merge pull request #118 from Hailinx/master
qihao27 Nov 13, 2017
a141beb
update help message for "lock" command
Hailinx Nov 13, 2017
3b2cbbc
Merge branch 'master' of https://github.com/Hailinx/addressbook-level4
Hailinx Nov 13, 2017
957c65a
Merge pull request #11 from CS2103AUG2017-T10-B1/master
Hailinx Nov 13, 2017
4e663ab
Merge branch 'master' of https://github.com/Hailinx/addressbook-level4
Hailinx Nov 13, 2017
cc3237e
Update sampledata
Hailinx Nov 13, 2017
2ff6027
Update testscript
Hailinx Nov 13, 2017
e1a89a7
Merge pull request #119 from Hailinx/master
qihao27 Nov 13, 2017
f744711
Merge pull request #5 from CS2103AUG2017-T10-B1/master
qihao27 Nov 13, 2017
3e4011b
Update docs
qihao27 Nov 13, 2017
ba45262
Minor updates to PPP
qihao27 Nov 13, 2017
ef5a814
Merge pull request #121 from qihao27/master
Hailinx Nov 13, 2017
fc66d29
Merge pull request #12 from CS2103AUG2017-T10-B1/master
Hailinx Nov 13, 2017
bf23e61
update docs
Hailinx Nov 13, 2017
b514138
Update UG (undo redo)
aaronyhsoh Nov 13, 2017
b58d078
update UG (add)
aaronyhsoh Nov 13, 2017
69db0fe
update ug (add)
aaronyhsoh Nov 13, 2017
d836583
Update docs
Hailinx Nov 13, 2017
22ae95f
Merge pull request #122 from Hailinx/master
qihao27 Nov 13, 2017
90bbd1d
Update AboutUs, PPP, TestScript
qihao27 Nov 13, 2017
1e1bd27
Merge pull request #6 from CS2103AUG2017-T10-B1/master
qihao27 Nov 13, 2017
60a65aa
Merge branch 'master' of https://github.com/qihao27/addressbook-level4
qihao27 Nov 13, 2017
597a96f
Add portfolio link
qihao27 Nov 13, 2017
90ce45e
Merge pull request #123 from qihao27/master
Hailinx Nov 13, 2017
4cda218
Update developer guide
aaronyhsoh Nov 13, 2017
85d52cb
Update UG (undo and redo enhanced)
aaronyhsoh Nov 13, 2017
eaab96a
Update UG (rewrite enhanced redo and undo)
aaronyhsoh Nov 13, 2017
ebb8220
Update UG (redocomand)
aaronyhsoh Nov 13, 2017
4241a2c
Update UG formatting
aaronyhsoh Nov 13, 2017
b7f234b
Final update
aaronyhsoh Nov 13, 2017
f81a95e
Merge branch 'master' into master
aaronyhsoh Nov 13, 2017
2b76c29
Merge branch 'master' into master
aaronyhsoh Nov 13, 2017
e8967b9
Add valensia's PPP
aaronyhsoh Nov 13, 2017
c234d83
Rename Valensia Sebastiani to Valensia Sebastiani.adoc
aaronyhsoh Nov 13, 2017
f9ebcc1
Rectifying Travis checkstyle error
aaronyhsoh Nov 13, 2017
bddd037
Update PPP
aaronyhsoh Nov 13, 2017
050be77
Update AaronSoh.adoc
aaronyhsoh Nov 13, 2017
9c73223
Update UserGuide.adoc
aaronyhsoh Nov 13, 2017
18416c7
Update AaronSoh.adoc
aaronyhsoh Nov 13, 2017
8b592f4
Update AaronSoh.adoc
aaronyhsoh Nov 13, 2017
70a3cf0
Update DeveloperGuide.adoc
aaronyhsoh Nov 13, 2017
09a71db
Update AaronSoh.adoc
aaronyhsoh Nov 13, 2017
faf6696
Update AaronSoh.adoc
aaronyhsoh Nov 13, 2017
e16ce3a
Update UserGuide.adoc
aaronyhsoh Nov 13, 2017
41a8f10
Update AaronSoh.adoc
aaronyhsoh Nov 13, 2017
91153f2
Update AaronSoh.adoc
aaronyhsoh Nov 13, 2017
5b75d32
Merge pull request #125 from aaronyhsoh/master
aaronyhsoh Nov 13, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
287 changes: 286 additions & 1 deletion docs/DeveloperGuide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ifdef::env-github[]
:note-caption: :information_source:
endif::[]
ifdef::env-github,env-browser[:outfilesuffix: .adoc]
:repoURL: https://github.com/se-edu/addressbook-level4/tree/master
:repoURL: https://github.com/CS2103-T10-B1/addressbook-level4/tree/master

By: `Team SE-EDU`      Since: `Jun 2016`      Licence: `MIT`

Expand Down Expand Up @@ -729,8 +729,26 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un

|`* * *` |user |find a person by name |locate details of persons without having to go through the entire list

|`* * *` |user |add details to a certain contact after adding them |have more information available afterwards

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it more like edit?


|`* * *` |user |be notified if I were to delete a contact |I don’t mistakenly delete a contact

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more like a detail that should be recorded in the use case of delete contact's user story.


|`* * *` |user |have a more flexible addition of contact |add contacts without address or email as compulsory elements

|`* * *` |user |show list of favourite contacts |quickly find people I contact often

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a user story to add contacts into favourite contacts.


|`* * *` |user |be notified when entering user with same name |avoid confusion in the future

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More like a use case.


|`* *` |user |hide link:#private-contact-detail[private contact details] by default |minimize chance of someone else seeing them by accident

|`* *` |user |use link:#right-click-menu[right click menu] for most link:#common-commands[common commands] |no typing is required and makes my life easy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember that the project defines that the user is a typist.


|`* *` |user |show contact according to categories of labels |access certain group by label

|`* *` |user |copy email address to clipboard |paste it into my email application’s recipients field

|`* *` |user |have wrong command to be highlighted |change it immediately

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in NFR.


|`*` |user with many persons in the address book |sort persons by name |locate a person easily
|=======================================================================

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the user stories follow the correct form. However, some are not user stories, instead they should be in use case or NFR. Please update them accordingly. Also, don't forget to define the target user.


Expand Down Expand Up @@ -767,6 +785,255 @@ Use case ends.
+
Use case resumes at step 2.

[discrete]
=== Use case: Add person details

*MSS*

1. User requests to create a contact with more details including birthday, home call number and so on
2. User types in these details

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a use case should show back and forth interaction between user and the system. Thus, it's incorrect to have consecutive user or system interactions.

3. AddressBook adds a new contact with these details
+
Use case ends.

*Extensions*

[none]
* 2a. User types with wrong format.
+
[none]
** 2a1. AddressBook shows an error message.
+
Use case ends.

[discrete]
=== Use case: Use right click menu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better if you write the use cases for edit and delete separately.


*MSS*

1. User requests to delete or edit one person
2. User right clicks that contact
3. AddressBook displays a menu with delete and edit options
4. User choose delete option
5. AddressBook delete that contact
+
Use case ends.

*Extensions*

[none]
* 4a. User choose edit option.
+
[none]
** 4a1. AddressBook shows a dialogue for editing.
** 4a2. User types in information.
** 4a3. AddressBook saves these information.
+
Use case ends.

[discrete]
=== Use case: Show contact according to categories of labels

*MSS*

1. User requests to show all persons with a specific label
2. AddressBook shows a list a person
+
Use case ends.

*Extensions*

[none]
* 1a. The label does not exist.
+
[none]
** 1a1. AddressBook shows a empty list.
+
Use case ends.

[discrete]
=== Use case: Delete confirmation

*MSS*

1. User requests to list persons
2. AddressBook shows a list of persons
3. User requests to delete a specific person in the list
4. AddressBook displays a dialogue window asking user to confirm deletion
5. User confirms deletion request
6. AddressBook deletes the person
+
Use case ends.

*Extensions*

[none]
* 1a. The given index is invalid.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does listing persons require index?

+
[none]
** 1a1. AddressBook shows an error message.
+
Use case ends.

[none]
* 3a. The given index is invalid.
+
[none]
** 3a1. AddressBook shows an error message.
+
Use case resumes at step 2.

[none]
* 5a. User cancels deletion.
+
Use case ends.

[discrete]
=== Use case: Flexible contact addition

*MSS*

1. User requests to add a person
2. User inputs desired details, eg: address, email, birthday, etc...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 1 and 2 can be combined into User requests to add a person with some missing attributes

3. AddressBook adds the person to the list
+
Use case ends.

*Extensions*

[none]
* 2a. The user input is invalid.
+
[none]
** 2a1. AddressBook shows an error message.
+
Use case ends.

[discrete]
=== Use case: Copy email address

*MSS*

1. User requests to list persons
2. AddressBook shows a list of persons
3. User requests to copy a specific person’s email address to clipboard
4. AddressBook copy the person’s email address to clipboard
+
Use case ends.

*Extensions*

[none]
* 2a. The list is empty.
+
Use case ends.

* 3a. The specified person’s email address is empty.
+
[none]
** 3a1. AddressBook shows an error message.
+
Use case resumes at step 2.

[discrete]
=== Use case: Favourite contacts

*MSS*

1. User requests to list commonly contacted persons
2. AddressBook saves and displays list without command
+
Use case ends.

*Extensions*

[none]
* 1a. The list is empty.
+
Use case ends.

[discrete]
=== Use case: Highlight contacts with same name

*MSS*

1. User requests to add a person
2. AddressBook notify if name entered matches any name in list
3. User edit the name of contact
4. AddressBook removes the notification
+
Use case ends.

[discrete]
=== Use case: Highlight invalid command

*MSS*

1. User inputs command
2. AddressBook highlights invalid command
3. User edits command
4. Addressbook removes highlight
+
Use case ends.

*Extensions*

[none]
* 2a. Command entered is valid.
+
Use case ends.

[discrete]
=== Use case: Add photos to contacts

*MSS*

1. User requests to list persons
2. AddressBook shows a list of persons
3. User picks a person
4. User requests to add a photo to contacts
5. AddressBook adds photo to contact
+
Use case ends.

*Extensions*

[none]
* 2a. The list is empty.
+
Use case ends.

* 4a. Contact already has a photo.
+
[none]
** 4a1. AddressBook displays message “already has a photo”.
+
** 4a2. AddressBook displays a dialogue window asking user if user wants to change the current photo.
+
Use case resumes at step 5.

[discrete]
=== Use case: Password feature

*MSS*

1. User runs the application
2. AddressBook displays a window asking user to input password
3. User inputs password
4. AddressBook displays main window
+
Use case ends.

*Extensions*

[none]
* 3a. User inputs wrong password.
+
[none]
** 3a1. AddressBook displays message “Wrong password”.
+
Use case resumes at step 2.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's good that you write use cases for each user stories, but some of them shouldn't be a user stories and also some use cases are wrong. Please check them again and update it accordingly.

{More to be added}

[appendix]
Expand All @@ -775,6 +1042,10 @@ Use case resumes at step 2.
. Should work on any link:#mainstream-os[mainstream OS] as long as it has Java `1.8.0_60` or higher installed.
. Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.
. A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.
. Should be able to sort within 1 second.
. A user with average software using skills should be able to understand the user interface within 20 minutes.
. A new user who is able to comprehend simple english can use the application within 20 minutes.
. Should only store data locally unless user shares with other applications.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, all NFRs are specific.


{More to be added}

Expand All @@ -795,6 +1066,20 @@ Private contact detail
A contact detail that is not meant to be shared with others
....

[[right-click-menu]]
Right click menu

....
A drop down menu that contains various commands
....

[[common-commands]]
Common commands

....
edit, delete
....

[appendix]
== Product Survey

Expand Down
2 changes: 1 addition & 1 deletion docs/UserGuide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ifdef::env-github[]
:tip-caption: :bulb:
:note-caption: :information_source:
endif::[]
:repoURL: https://github.com/se-edu/addressbook-level4
:repoURL: https://github.com/CS2103-T10-B1/addressbook-level4

By: `Team SE-EDU` Since: `Jun 2016` Licence: `MIT`

Expand Down
1 change: 1 addition & 0 deletions src/main/java/seedu/address/logic/commands/AddCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
public class AddCommand extends UndoableCommand {

public static final String COMMAND_WORD = "add";
public static final String COMMAND_ALIAS = "a";

public static final String MESSAGE_USAGE = COMMAND_WORD + ": Adds a person to the address book. "
+ "Parameters: "
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
public class ClearCommand extends UndoableCommand {

public static final String COMMAND_WORD = "clear";
public static final String COMMAND_ALIAS = "c";
public static final String MESSAGE_SUCCESS = "Address book has been cleared!";


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
public class DeleteCommand extends UndoableCommand {

public static final String COMMAND_WORD = "delete";
public static final String COMMAND_ALIAS = "d";

public static final String MESSAGE_USAGE = COMMAND_WORD
+ ": Deletes the person identified by the index number used in the last person listing.\n"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
public class EditCommand extends UndoableCommand {

public static final String COMMAND_WORD = "edit";
public static final String COMMAND_ALIAS = "e";

public static final String MESSAGE_USAGE = COMMAND_WORD + ": Edits the details of the person identified "
+ "by the index number used in the last person listing. "
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
public class FindCommand extends Command {

public static final String COMMAND_WORD = "find";
public static final String COMMAND_ALIAS = "f";

public static final String MESSAGE_USAGE = COMMAND_WORD + ": Finds all persons whose names contain any of "
+ "the specified keywords (case-sensitive) and displays them as a list with index numbers.\n"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
public class HistoryCommand extends Command {

public static final String COMMAND_WORD = "history";
public static final String COMMAND_ALIAS = "h";
public static final String MESSAGE_SUCCESS = "Entered commands (from most recent to earliest):\n%1$s";
public static final String MESSAGE_NO_HISTORY = "You have not yet entered any commands.";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
public class ListCommand extends Command {

public static final String COMMAND_WORD = "list";
public static final String COMMAND_ALIAS = "l";

public static final String MESSAGE_SUCCESS = "Listed all persons";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
public class RedoCommand extends Command {

public static final String COMMAND_WORD = "redo";
public static final String COMMAND_ALIAS = "r";
public static final String MESSAGE_SUCCESS = "Redo success!";
public static final String MESSAGE_FAILURE = "No more commands to redo!";

Expand Down
Loading