[Lim Wen Feng] iP #98
Conversation
src/main/java/Duke.java
Outdated
| tasksCount++; | ||
| System.out.println("Added: " + userCommand[0]); | ||
| notifyUser(inputDetails, selectedTask); | ||
|
|
src/main/java/Duke.java
Outdated
| public class Duke { | ||
| private static final Scanner SCANNER = new Scanner(System.in); |
src/main/java/Task.java
Outdated
| public String getTaskType() { | ||
| if (this.taskType.equalsIgnoreCase("todo")) { | ||
| return "[T]"; | ||
| } else if (this.taskType.equalsIgnoreCase("deadline")) { | ||
| return "[D]"; | ||
| } else { | ||
| return "[E]"; | ||
| } |
src/main/java/Duke.java
Outdated
| exitDuke(); | ||
| break; | ||
| } | ||
| if (userCommand.equalsIgnoreCase("list")){ |
There was a problem hiding this comment.
Maybe use boolean variables to make this easier to understand
src/main/java/Task.java
Outdated
| public void markAsDone() { | ||
| this.isDone = true; | ||
| } | ||
|
|
||
| public String getTaskType() { |
src/main/java/Duke.java
Outdated
| } | ||
| else if (isValidInput(userCommand)){ | ||
| processUserRequest(userCommand, inputDetails); | ||
| } else { |
src/main/java/Task.java
Outdated
|
|
||
| public Task(String description) { | ||
| public Task(String description, String taskType) { |
src/main/java/Duke.java
Outdated
| @@ -80,7 +98,7 @@ private static void listOutTasks() { | |||
| while (i < tasksCount) { | |||
| Task selectedTask = tasksList[i]; | |||
| i++; | |||
| System.out.println(i + ". " + selectedTask.getStatusIcon() + " " + selectedTask.description); | |||
| System.out.println(i + ". " + selectedTask.getTaskType() + selectedTask.getStatusIcon() + " " + selectedTask.description); | |||
| } | |||
| } | |||
|
|
|||
Branch level 6
src/main/java/Duke.java
Outdated
| @@ -1,10 +1,239 @@ | |||
| import java.io.*; | |||
There was a problem hiding this comment.
You may wish to consider explicitly importing the classes that you wish to use here to increase clarity of what classes are to be maintained here.
src/main/java/Duke.java
Outdated
| printLine(); | ||
| printLine(); |
There was a problem hiding this comment.
It seems you have repeated lines of code here. Consider reviewing what is redundant.
| @@ -0,0 +1,13 @@ | |||
| package Duke; | |||
There was a problem hiding this comment.
Good job in keeping this class simple and easy to read.
src/main/java/Duke/Task.java
Outdated
| protected String taskType; | ||
|
|
||
| public Task(String description, String taskType) { | ||
| if (taskType.equalsIgnoreCase("event")) { |
There was a problem hiding this comment.
This constructor class seems to be lengthy for the start. You could abstract away some details, while ensuring SLAP.
src/main/java/Duke/Task.java
Outdated
| this.isDone = false; | ||
| this.taskType = taskType; | ||
| } | ||
| else if (taskType.equalsIgnoreCase("deadline")) { |
There was a problem hiding this comment.
You have several cases here. Instead of multiple else if, perhaps explicit switch case statements could be, See switch layouts: https://se-education.org/guides/conventions/java/basic.html#layout.
implemented find features
No description provided.