Update week4 progress and knowledge

nus-cs3281 · Feb 5, 2025 · 056b177 · 056b177
1 parent e38e7f6
commit 056b177
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/students/yucongkoo/knowledge.md b/students/yucongkoo/knowledge.md
@@ -20,3 +20,14 @@ As a developer coming from React, here are some clear differences I have observe
 
 - There is no concept of states in Angular and the data passing is 2-ways, when the user updates from the UI, the value is automatically updated in the component and vice versa, whereas in React we would have to use states and explicitly update the states via setState or similar functions.
 - Instead of defining the layout of componenet and logic in the same file, Angular split them into 2 seperate files (i.e. the html and typescript file), personally I felt that this split helps enforce the MVC architecture more strictly, but also imposes more restrictions when it comes to components that have tightly coupled logic
+
+### CATcher
+
+#### IssueTablesComponent and how issues are being shown in tables
+
+While working on issue [#1309](https://github.com/CATcher-org/CATcher/issues/1309), I had to delve deep into how the the IssueTablesComponent is implemented in order to create new tables. A few meaningful observations learnt is summarised as follows:
+
+- The issues displayed in the table is mainly dependent on 2 things,
+  - The base issues data provided by `IssueService`, which is initialized based on `IssuesFilter`, and will periodically pull the issues from github
+  - The `filters` we inject when creating the `IssueTablesComponent`, where the base issues can be filtered down to the issues that we are concerned of
+  - The action buttons and its respective functionalities are pre-defined in the `IssueTableComponent` itself, we only specify the action buttons that we want when creating the `IssuesTablesComponent` through the `actions` input.
diff --git a/students/yucongkoo/progress.md b/students/yucongkoo/progress.md
@@ -1,6 +1,9 @@
-| Week | Achievements                                                                                                                                                                  |
-| ---- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| 1    | Merged PR : [Fix formatting style of issue-table component](https://github.com/CATcher-org/CATcher/pull/1291)                                                                 |
-| 1    | Submitted and Researched Issue: [Playwright Github workflow failing #1292](https://github.com/CATcher-org/CATcher/issues/1292)                                                |
-| 2    | Merged PR: [Downgrade ubuntu version in playwright.yml #1298](https://github.com/CATcher-org/CATcher/pull/1298)                                                               |
-| 2    | Participated in Issue Investigation : [Workflow failing due to updated nested dependencies #1304](https://github.com/CATcher-org/CATcher/issues/1304#issuecomment-2609636737) |
+| Week | Achievements                                                                                                                                                                                                                                  |
+| ---- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| 1    | Merged PR : [Fix formatting style of issue-table component](https://github.com/CATcher-org/CATcher/pull/1291)                                                                                                                                 |
+| 1    | Submitted and Researched Issue: [Playwright Github workflow failing #1292](https://github.com/CATcher-org/CATcher/issues/1292)                                                                                                                |
+| 2    | Merged PR: [Downgrade ubuntu version in playwright.yml #1298](https://github.com/CATcher-org/CATcher/pull/1298)                                                                                                                               |
+| 2    | Participated in Issue Investigation : [Workflow failing due to updated nested dependencies #1304](https://github.com/CATcher-org/CATcher/issues/1304#issuecomment-2609636737)                                                                 |
+| 4    | Reported and Researched Bug: [Problematic RestGithubIssueState value #1310](https://github.com/CATcher-org/CATcher/issues/1310)                                                                                                               |
+| 4    | Merged PR: [Fix RestGithubIssueState value for closed states #1311](https://github.com/CATcher-org/CATcher/pull/1311)                                                                                                                         |
+| 4    | Initiated and participated in discussion of UI and user workflow for new bug-trimming phase: [Create new UI for bug reporting phase that allows deleting and un-deleting of issues #1309](https://github.com/CATcher-org/CATcher/issues/1309) |