enable pairs/ipairs and next for ILuaUserData #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if anything should be changed or improved. |
Akeit0
requested changes
Aug 23, 2025
| namespace Lua; | ||
|
|
||
| public sealed class LuaTable : IEnumerable<KeyValuePair<LuaValue, LuaValue>> | ||
| public interface ILuaEnumerable |
There was a problem hiding this comment.
Separate files for this interface.
| } | ||
| else if (arg0.TryRead(out ILuaUserData userdata)) | ||
| { | ||
| metatable = userdata.Metatable; |
There was a problem hiding this comment.
Instead, use LuaState.TryGetMetatable.
| metatable = table.Metatable; | ||
| } | ||
| else if (arg0.TryRead(out ILuaUserData userdata)) | ||
| { |
There was a problem hiding this comment.
Instead, use LuaState.TryGetMetatable.
Comment on lines
+1
to
+2
| // Copyright (C) 2021-2025 Steffen Itterheim | ||
| // Refer to included LICENSE file for terms and conditions. |
There was a problem hiding this comment.
This is not your repository.
There was a problem hiding this comment.
sorry about that, it's an automation in my IDE that adds these
|
To be honest, I don't like the addition of |
|
I think it's not bad that we can iterate key/values without preparing the original __pairs and next, but it may be debatable whether it's worth adding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a need for pairs/ipairs to work on userdata so I went ahead.
For "next" to support enumeration of userdata I had to add a
ILuaEnumerable.I'll add a test case as soon as I figured out where that went (it's stashed somewhere, I hope).
In relation to #205
#205