Replace QQuickView with QQuickWidget for Kanban view
#756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjeffer
approved these changes
Sep 15, 2025
|
Thanks a lot for this and sorry for the delay! I'll be testing this now... |
|
So, this PR causes macOS windows to default to the default title bar. But I got a fixed for that. I''ll create a separate PR. I can't really test on a Linux machine so I'm taking your word that it works. @guihkx can you just also make sure it works in X11 session so we don't have any regression? After testing, please merge this. I tested on Windows - seems to work well. |
nuttyartist
approved these changes
Oct 12, 2025
|
Thanks for testing!
Yup, I did. And I tested on Wayland and on Windows 10 well. Everything looks the same to me. I'll just rebase against current master and merge it. Thanks! |
Qt docs note that QWidget::createWindowContainer has a number of known limitations, with one of them being focus handling. [1] On Wayland, that limitation seems to be preventing us from typing anything into the Kanban view, because it never gains focus. [1] https://doc.qt.io/qt-6/qwidget.html#createWindowContainer
guihkx
force-pushed
the
fix-kanban-typing-wayland
branch
from
2865f1f to
155819c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt docs note that
QWidget::createWindowContainerhas a number of known limitations, with one of them being focus handling.On Wayland, that limitation seems to be preventing us from typing anything into the Kanban view, because it never gains focus.
Fixes #617
I've tested this on Linux (on both X11 and Wayland sessions), Windows 10, and I didn't notice any difference in behavior compared to the previous approach.
I've also tested the pre-built DEB and RPM packages on their appropriate target distros.
cc @nuttyartist: Can you please test this on macOS? Thanks!