perf(utils): optimize slice functions #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuxencs
added
Area: Utilities
zze0s
approved these changes
Aug 25, 2024
nuxencs
force-pushed
the
perf/optimize-slice-utils
branch
from
979beb4 to
949df72
Compare
nuxencs
added a commit
that referenced
this pull request
Aug 31, 2024
* perf(utils): optimize slice functions * test(utils): added tests for SimplifyHDRSlice
nuxencs
added a commit
that referenced
this pull request
Sep 4, 2024
* feat(notifications): filter notifications * fix(notifications): default slice not overwriting correctly * chore(logging): move notification skip logging to debug level * refactor: receivers and var names (#131) * perf(utils): optimize slice functions (#132) * perf(utils): optimize slice functions * test(utils): added tests for SimplifyHDRSlice * refactor(notifications): map notification level to status codes * fix(config): workaround for viper not overwriting slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizing runtime, and memory usage for the utility functions for slices.
EqualElementsnow uses a frequency map to avoid having to sort the slices to compare and is now genericDedupeSlicenow uses a string to empty struct map, that way we don't need to check for the bool values anymore and have the advantage that the empty struct doesn't take up any memorySimplifyHDRSliceremoved the if check for zero-length slices as go already handles that