Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(processor): improve logging with more context #95

Merged
merged 11 commits into from
Apr 10, 2024

Conversation

nuxencs
Copy link
Owner

@nuxencs nuxencs commented Mar 30, 2024

This adds more context around the processor logic to make debugging easier.

@nuxencs nuxencs added Type: Enhancement Improvement of the current situation Area: Logging Related to the logging labels Mar 30, 2024
@nuxencs nuxencs added this to the v0.8.0 milestone Mar 30, 2024
@nuxencs nuxencs changed the title chore(processor): don't treat not matching as error chore(processor): improve logging with more context Mar 30, 2024
Copy link

@zze0s zze0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I get the idea of this change, but I don't really see an issue with the previous approach of returning errors as before 🤔

Logging in the caller after the error check and have for example the success log there is the idiomatic thing to do.

@nuxencs
Copy link
Owner Author

nuxencs commented Apr 5, 2024

Hmmm if you think the old approach makes more sense I will leave it like it was.

What do you think about passing the name of the release, and maybe the client name, through the key value pair of With().Str()?

@zze0s
Copy link

zze0s commented Apr 8, 2024

Hmmm if you think the old approach makes more sense I will leave it like it was.

What do you think about passing the name of the release, and maybe the client name, through the key value pair of With().Str()?

Yeah extra context info is great, makes it easier to debug 👍

@nuxencs nuxencs merged commit 7f92578 into develop Apr 10, 2024
10 checks passed
@nuxencs nuxencs deleted the chore/dont-treat-not-matching-as-errors branch April 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Logging Related to the logging Type: Enhancement Improvement of the current situation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants