-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(processor): improve logging with more context #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I get the idea of this change, but I don't really see an issue with the previous approach of returning errors as before 🤔
Logging in the caller after the error check and have for example the success log there is the idiomatic thing to do.
Hmmm if you think the old approach makes more sense I will leave it like it was. What do you think about passing the name of the release, and maybe the client name, through the key value pair of |
Yeah extra context info is great, makes it easier to debug 👍 |
This adds more context around the processor logic to make debugging easier.