-
Notifications
You must be signed in to change notification settings - Fork 19
fix: yaml files behavior #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7b9f264
fix: remove yaml line limit
farnabaz b61e0fc
fix: yaml/json deep compare
farnabaz bf032e8
fix: yaml compare
farnabaz 26ef040
chore: upgrade deps
farnabaz da52151
test: add test for `isEqual`
farnabaz d7f2bb0
fix prerendering issue
larbish 0673ce3
deps up
larbish 36d1aa2
fix typecheck
larbish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code will crash if document body is
nulldue to how JavaScript'stypeofoperator treats null as 'object', combined withisDeepEqualnot handling null values properly.View Details
Analysis
TypeError in isEqual() when comparing documents with null body
What fails:
isEqual()function insrc/app/src/utils/database.tscrashes when comparing documents with null body values due totypeof null === 'object'causing incorrect branch selectionHow to reproduce:
Result:
TypeError: Cannot convert undefined or null to objectatObject.keys(null)call inisDeepEqual()functionExpected: Should handle null body values without crashing, falling back to JSON.stringify comparison
Root cause: Line 32 condition
typeof body1 === 'object' && typeof body2 === 'object'evaluates totruefor null values due to JavaScript'stypeof null === 'object'behavior, incorrectly routing null values toisDeepEqual()which callsObject.keys(null)