Skip to content

feat(github): allow defining custom redirect_url #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

feat(github): allow defining custom redirect_url #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd5a94e
feat(github): allow defining custom redirect_url
hendrikheil Nov 5, 2025
6229e6f
chore use proper env
atinux Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/module/src/runtime/server/routes/auth/github.get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ import { useRuntimeConfig } from '#imports'
export interface OAuthGitHubConfig {
/**
* GitHub OAuth Client ID
* @default process.env.NUXT_OAUTH_GITHUB_CLIENT_ID
* @default process.env.STUDIO_GITHUB_CLIENT_ID
*/
clientId?: string
/**
* GitHub OAuth Client Secret
* @default process.env.NUXT_OAUTH_GITHUB_CLIENT_SECRET
* @default process.env.STUDIO_GITHUB_CLIENT_SECRET
*/
clientSecret?: string
/**
Expand Down Expand Up @@ -58,8 +58,8 @@ export interface OAuthGitHubConfig {

/**
* Redirect URL to to allow overriding for situations like prod failing to determine public hostname
* @default process.env.NUXT_OAUTH_GITHUB_REDIRECT_URL
* @see https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/differences-between-github-apps-and-oauth-apps
* Use `process.env.STUDIO_GITHUB_REDIRECT_URL` to overwrite the default redirect URL.
* @default is ${hostname}/__nuxt_studio/auth/github
*/
redirectURL?: string
}
Expand All @@ -83,6 +83,7 @@ export default eventHandler(async (event: H3Event) => {
const config = defu(useRuntimeConfig(event).studio?.auth?.github, {
clientId: process.env.STUDIO_GITHUB_CLIENT_ID,
clientSecret: process.env.STUDIO_GITHUB_CLIENT_SECRET,
redirectURL: process.env.STUDIO_GITHUB_REDIRECT_URL,
authorizationURL: 'https://github.com/login/oauth/authorize',
tokenURL: 'https://github.com/login/oauth/access_token',
apiURL: 'https://api.github.com',
Expand All @@ -109,7 +110,9 @@ export default eventHandler(async (event: H3Event) => {
}

const requestURL = getRequestURL(event)
const redirectURL = `${requestURL.protocol}//${requestURL.host}${requestURL.pathname}`

config.redirectURL = config.redirectURL || `${requestURL.protocol}//${requestURL.host}${requestURL.pathname}`

const state = await handleState(event)

if (!query.code) {
Expand All @@ -125,7 +128,7 @@ export default eventHandler(async (event: H3Event) => {
event,
withQuery(config.authorizationURL as string, {
client_id: config.clientId,
redirect_uri: redirectURL,
redirect_uri: config.redirectURL,
scope: config.scope.join(' '),
state,
...config.authorizationParams,
Expand All @@ -149,7 +152,7 @@ export default eventHandler(async (event: H3Event) => {
grant_type: 'authorization_code',
client_id: config.clientId,
client_secret: config.clientSecret,
redirect_uri: redirectURL,
redirect_uri: config.redirectURL,
code: query.code,
},
})
Expand Down
Loading