Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Skeleton): accesbility #3613

Open
wants to merge 18 commits into
base: v3
Choose a base branch
from
Open

fix(Skeleton): accesbility #3613

wants to merge 18 commits into from
+9 −2

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Mar 19, 2025 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

rdjanuar and others added 17 commits January 9, 2025 14:56
@rdjanuar
fix(InputMenu): removing tag does not change modelValue
2955342
@rdjanuar
up
Loading
Loading status checks…
40e4f29
@rdjanuar
fix: ci
Loading
Loading status checks…
0bef321
@rdjanuar
fix: typecheck
Loading
Loading status checks…
3add3ca
@rdjanuar
fix: typecheck
Loading
Loading status checks…
303de41
@rdjanuar
fix: typecheck
Loading
Loading status checks…
8ba0eac
@benjamincanac
Merge branch 'v3' into v3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
320a19d
@benjamincanac
up
Loading
Loading status checks…
bffae79
@rdjanuar
fix(SelectMenu): resetSearchTermOnBlur does not work
2a648d6
@rdjanuar
Merge branch 'v3' of github.com-rdjanuar:rdjanuar/ui into v3
Loading
Loading status checks…
affb705
@rdjanuar
Merge branch 'v3' into v3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
fc5bccf
@rdjanuar
up
59be033
@rdjanuar
up
7918edb
@rdjanuar
up
bcd703a
@rdjanuar
Merge branch 'v3' of github.com-rdjanuar:rdjanuar/ui into v3
Loading
Loading status checks…
e8a125f
@rdjanuar
fix(Skeleton): add ARIA accessibility attributes
aece5f5
@rdjanuar
Merge branch 'v3' into fix/accessibility-skeleton

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
2832f9c
@rdjanuar rdjanuar changed the title Fix/accessibility skeleton fix(Skeleton): accesbility Mar 19, 2025
@rdjanuar
up
Loading
Loading status checks…
2027925
@benjamincanac Volta.net
Copy link
Member

Is there some reference docs to back up this? 🤔

@rdjanuar
Copy link
Collaborator Author

https://adrianroselli.com/2020/11/more-accessible-skeletons.html @benjamincanac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdjanuar @benjamincanac